Netdev List
 help / color / mirror / Atom feed
From: "luis.la@mail.de" <luis.la@mail.de>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>,
	netdev@vger.kernel.org
Cc: Andrew Lunn <andrew@lunn.ch>, Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
	Ovidiu Panait <ovidiu.panait.rb@renesas.com>,
	Oleksij Rempel <o.rempel@pengutronix.de>,
	Rohan G Thomas <rohan.g.thomas@altera.com>,
	"moderated list:ARM/STM32 ARCHITECTURE"
	<linux-stm32@st-md-mailman.stormreply.com>,
	"moderated list:ARM/STM32 ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: stmmac: dwmac4: mask interrupts before stopping DMA in suspend
Date: Mon, 20 Jul 2026 13:24:21 +0200	[thread overview]
Message-ID: <f141897b-6570-4a80-95bf-a8efd9d25785@mail.de> (raw)
In-Reply-To: <5cc0d788-c78d-40f2-998f-235d40f567f2@bootlin.com>

Hi Maxime,
> This is almost perfect for a new submission, only 2 things to improve :
> 
>  - you're missing the tree name in the patch subject. As this is a fix, it should be :
> 
>    [PATCH net] net: stmmac: dwmac4: mask interrupts before stopping DMA in suspend
> 
>    you can find instructions for this in the doc Andrew linked :
> 
>    https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
> 
>  - When submitting a patch, do so in a dedicated thread, and not in reply to
>    other threads.
> 
> You should send a V2 addressing the tree name in the patch subject.

Thanks for the feedback, I addressed these changes and sent a v2 patch.

> Sashiko noted something on the patch :
> 
>   https://sashiko.dev/#/patchset/20260718152802.83553-1-luis.la%40mail.de
> 
> It looks to me that sashiko is just wrong there though, I can't make sense
> of what it is saying.

This seems to be because strictly speaking the title of the commit was wrong,
the interrupts don't get deactivated before stopping dma.
I changed it, but only read after that it is discouraged to change the Subject, sorry...
I hope the patch now meets the requirements,
Luis


      reply	other threads:[~2026-07-20 11:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-16 20:10 [REGRESSION][BISECTED] stmmac: suspend hangs since 1b9707e6f1a9 ("net: stmmac: enable RPS and RBU interrupts") tresonic
2026-07-16 21:47 ` Andrew Lunn
2026-07-17  7:18   ` tresonic
2026-07-17 15:40     ` Andrew Lunn
2026-07-17 22:23       ` tresonic
2026-07-17 22:34         ` tresonic
2026-07-18  0:16         ` Andrew Lunn
2026-07-18  7:35           ` tresonic
2026-07-18 13:11             ` Maxime Chevallier
2026-07-18 13:32               ` tresonic
2026-07-18 14:11                 ` Andrew Lunn
2026-07-18 15:32                   ` tresonic
2026-07-18 14:06             ` Andrew Lunn
2026-07-18 15:27 ` [PATCH] net: stmmac: dwmac4: mask interrupts before stopping DMA in suspend Luis Lang
2026-07-20  9:33   ` Maxime Chevallier
2026-07-20 11:24     ` luis.la [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f141897b-6570-4a80-95bf-a8efd9d25785@mail.de \
    --to=luis.la@mail.de \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=maxime.chevallier@bootlin.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=ovidiu.panait.rb@renesas.com \
    --cc=pabeni@redhat.com \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=rohan.g.thomas@altera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox