From: David Ahern <dsa@cumulusnetworks.com>
To: David Miller <davem@davemloft.net>, roopa@cumulusnetworks.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: fib_rules: fix l3mdev netlink attr processing
Date: Mon, 23 Apr 2018 21:43:27 -0600 [thread overview]
Message-ID: <60931ebf-d72f-564e-b296-878454f4880a@cumulusnetworks.com> (raw)
In-Reply-To: <20180423.232158.1633374650832506893.davem@davemloft.net>
On 4/23/18 9:21 PM, David Miller wrote:
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
> Date: Mon, 23 Apr 2018 20:08:41 -0700
>
>> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>>
>> Fixes: b16fb418b1bf ("net: fib_rules: add extack support")
>> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
>
> Applied.
>
> It would be nice to get rid of these if() conditionals dangling
> around ifdef blocks. They are quite error prone.
>
I'll send a patch. I'd prefer a different message when NET_L3_MASTER_DEV
is not enabled.
prev parent reply other threads:[~2018-04-24 3:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 3:08 [PATCH net-next] net: fib_rules: fix l3mdev netlink attr processing Roopa Prabhu
2018-04-24 3:21 ` David Miller
2018-04-24 3:43 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60931ebf-d72f-564e-b296-878454f4880a@cumulusnetworks.com \
--to=dsa@cumulusnetworks.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox