* [PATCH v2] rsi: remove set but not used variable 'header_size'
@ 2018-08-31 11:13 YueHaibing
2018-09-01 3:41 ` Siva Rebbagondla
0 siblings, 1 reply; 3+ messages in thread
From: YueHaibing @ 2018-08-31 11:13 UTC (permalink / raw)
To: kvalo, davem
Cc: linux-kernel, netdev, amit.karwar, pavani.muthyala, keescook,
linux-wireless, YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/rsi/rsi_91x_hal.c: In function 'rsi_send_data_pkt':
drivers/net/wireless/rsi/rsi_91x_hal.c:288:5: warning:
variable 'header_size' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
v2: remove unused 'tx_params'
---
drivers/net/wireless/rsi/rsi_91x_hal.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/wireless/rsi/rsi_91x_hal.c b/drivers/net/wireless/rsi/rsi_91x_hal.c
index 01edf96..182b066 100644
--- a/drivers/net/wireless/rsi/rsi_91x_hal.c
+++ b/drivers/net/wireless/rsi/rsi_91x_hal.c
@@ -282,10 +282,8 @@ int rsi_send_data_pkt(struct rsi_common *common, struct sk_buff *skb)
struct rsi_hw *adapter = common->priv;
struct ieee80211_vif *vif;
struct ieee80211_tx_info *info;
- struct skb_info *tx_params;
struct ieee80211_bss_conf *bss;
int status = -EINVAL;
- u8 header_size;
if (!skb)
return 0;
@@ -297,8 +295,6 @@ int rsi_send_data_pkt(struct rsi_common *common, struct sk_buff *skb)
goto err;
vif = info->control.vif;
bss = &vif->bss_conf;
- tx_params = (struct skb_info *)info->driver_data;
- header_size = tx_params->internal_hdr_size;
if (((vif->type == NL80211_IFTYPE_STATION) ||
(vif->type == NL80211_IFTYPE_P2P_CLIENT)) &&
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] rsi: remove set but not used variable 'header_size'
2018-08-31 11:13 [PATCH v2] rsi: remove set but not used variable 'header_size' YueHaibing
@ 2018-09-01 3:41 ` Siva Rebbagondla
2018-09-01 6:54 ` YueHaibing
0 siblings, 1 reply; 3+ messages in thread
From: Siva Rebbagondla @ 2018-09-01 3:41 UTC (permalink / raw)
To: yuehaibing
Cc: Kalle Valo, davem, linux-kernel, netdev, Amit karwar,
pavani.muthyala, keescook, Linux Wireless
On Fri, Aug 31, 2018 at 4:45 PM YueHaibing <yuehaibing@huawei.com> wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/rsi/rsi_91x_hal.c: In function 'rsi_send_data_pkt':
> drivers/net/wireless/rsi/rsi_91x_hal.c:288:5: warning:
> variable 'header_size' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> v2: remove unused 'tx_params'
> ---
> drivers/net/wireless/rsi/rsi_91x_hal.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/wireless/rsi/rsi_91x_hal.c b/drivers/net/wireless/rsi/rsi_91x_hal.c
> index 01edf96..182b066 100644
> --- a/drivers/net/wireless/rsi/rsi_91x_hal.c
> +++ b/drivers/net/wireless/rsi/rsi_91x_hal.c
> @@ -282,10 +282,8 @@ int rsi_send_data_pkt(struct rsi_common *common, struct sk_buff *skb)
> struct rsi_hw *adapter = common->priv;
> struct ieee80211_vif *vif;
> struct ieee80211_tx_info *info;
> - struct skb_info *tx_params;
> struct ieee80211_bss_conf *bss;
> int status = -EINVAL;
> - u8 header_size;
>
> if (!skb)
> return 0;
> @@ -297,8 +295,6 @@ int rsi_send_data_pkt(struct rsi_common *common, struct sk_buff *skb)
> goto err;
> vif = info->control.vif;
> bss = &vif->bss_conf;
> - tx_params = (struct skb_info *)info->driver_data;
> - header_size = tx_params->internal_hdr_size;
Yes, These redundant variables shall be removed.
>
> if (((vif->type == NL80211_IFTYPE_STATION) ||
> (vif->type == NL80211_IFTYPE_P2P_CLIENT)) &&
> --
> 2.7.0
>
>
Also, Patch title also can be changed to "[v2] rsi: remove unused variables"
Thanks,
Siva Rebbagondla
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] rsi: remove set but not used variable 'header_size'
2018-09-01 3:41 ` Siva Rebbagondla
@ 2018-09-01 6:54 ` YueHaibing
0 siblings, 0 replies; 3+ messages in thread
From: YueHaibing @ 2018-09-01 6:54 UTC (permalink / raw)
To: Siva Rebbagondla
Cc: Kalle Valo, davem, linux-kernel, netdev, Amit karwar,
pavani.muthyala, keescook, Linux Wireless
On 2018/9/1 11:41, Siva Rebbagondla wrote:
> On Fri, Aug 31, 2018 at 4:45 PM YueHaibing <yuehaibing@huawei.com> wrote:
>>
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/net/wireless/rsi/rsi_91x_hal.c: In function 'rsi_send_data_pkt':
>> drivers/net/wireless/rsi/rsi_91x_hal.c:288:5: warning:
>> variable 'header_size' set but not used [-Wunused-but-set-variable]
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> v2: remove unused 'tx_params'
>> ---
>> drivers/net/wireless/rsi/rsi_91x_hal.c | 4 ----
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/drivers/net/wireless/rsi/rsi_91x_hal.c b/drivers/net/wireless/rsi/rsi_91x_hal.c
>> index 01edf96..182b066 100644
>> --- a/drivers/net/wireless/rsi/rsi_91x_hal.c
>> +++ b/drivers/net/wireless/rsi/rsi_91x_hal.c
>> @@ -282,10 +282,8 @@ int rsi_send_data_pkt(struct rsi_common *common, struct sk_buff *skb)
>> struct rsi_hw *adapter = common->priv;
>> struct ieee80211_vif *vif;
>> struct ieee80211_tx_info *info;
>> - struct skb_info *tx_params;
>> struct ieee80211_bss_conf *bss;
>> int status = -EINVAL;
>> - u8 header_size;
>>
>> if (!skb)
>> return 0;
>> @@ -297,8 +295,6 @@ int rsi_send_data_pkt(struct rsi_common *common, struct sk_buff *skb)
>> goto err;
>> vif = info->control.vif;
>> bss = &vif->bss_conf;
>> - tx_params = (struct skb_info *)info->driver_data;
>> - header_size = tx_params->internal_hdr_size;
> Yes, These redundant variables shall be removed.
>>
>> if (((vif->type == NL80211_IFTYPE_STATION) ||
>> (vif->type == NL80211_IFTYPE_P2P_CLIENT)) &&
>> --
>> 2.7.0
>>
>>
> Also, Patch title also can be changed to "[v2] rsi: remove unused variables"
Ok, will fix in v3.
Thank you.
>
> Thanks,
> Siva Rebbagondla
>
> .
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-01 6:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-31 11:13 [PATCH v2] rsi: remove set but not used variable 'header_size' YueHaibing
2018-09-01 3:41 ` Siva Rebbagondla
2018-09-01 6:54 ` YueHaibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox