Netdev List
 help / color / mirror / Atom feed
* [PATCH net v2] bonding: fix slave_cnt leak on XDP error paths
@ 2026-09-03  8:10 Hangbin Liu
  2026-09-03  8:18 ` Nikolay Aleksandrov
                   ` (2 more replies)
  0 siblings, 3 replies; 12+ messages in thread
From: Hangbin Liu @ 2026-09-03  8:10 UTC (permalink / raw)
  To: Jay Vosburgh, Andrew Lunn, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Daniel Borkmann, Jussi Maki,
	Nikolay Aleksandrov
  Cc: Hangbin Liu, netdev, linux-kernel, Hangbin Liu

From: Hangbin Liu <liuhangbin@kylinos.cn>

When bond_enslave() succeeds up to the XDP setup stage, slave_cnt is
already incremented. If XDP setup subsequently fails, the error paths
jump directly to err_sysfs_del, bypassing the slave_cnt decrement.

This causes slave_cnt to drift upward on each failed enslaving attempt,
which would lead to unbalanced traffic distribution with round-robin
mode.

Fix it by moving the slave_cnt increasement after XDP setup.

Fixes: 9e2ee5c7e7c3 ("net, bonding: Add XDP support to the bonding driver")
Signed-off-by: Hangbin Liu <liuhangbin@kylinos.cn>
---
Changes in v2:
- move the slave_cnt increasement after XDP setup (Nikolay Aleksandrov)
- balance-xor mode is not affected, not mention it (Nikolay Aleksandrov)
- Link to v1: https://lore.kernel.org/r/20260902-bond_slave_cnt-v1-1-36e95bf4a6ff@kylinos.cn
---
 drivers/net/bonding/bond_main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 947d92a669b6..f3290aee50d1 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -2284,7 +2284,6 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev,
 		}
 	}
 
-	WRITE_ONCE(bond->slave_cnt, bond->slave_cnt + 1);
 	netdev_compute_master_upper_features(bond->dev, true);
 	bond_set_carrier(bond);
 
@@ -2339,6 +2338,8 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev,
 
 	bond_xdp_set_features(bond_dev);
 
+	WRITE_ONCE(bond->slave_cnt, bond->slave_cnt + 1);
+
 	slave_info(bond_dev, slave_dev, "Enslaving as %s interface with %s link\n",
 		   bond_is_active_slave(new_slave) ? "an active" : "a backup",
 		   new_slave->link != BOND_LINK_DOWN ? "an up" : "a down");

---
base-commit: 70f3995830d3f1e79faa14eb0605914f778feca9
change-id: 20260807-bond_slave_cnt-88e78c5f0ab9

Best regards,
-- 
Hangbin Liu <liuhangbin@kylinos.cn>


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH net v2] bonding: fix slave_cnt leak on XDP error paths
  2026-09-03  8:10 [PATCH net v2] bonding: fix slave_cnt leak on XDP error paths Hangbin Liu
@ 2026-09-03  8:18 ` Nikolay Aleksandrov
  2026-09-03  9:27   ` Hangbin Liu
  2026-09-03 10:38 ` Matthieu Baerts
  2026-09-04 14:11 ` [syzbot ci] " syzbot ci
  2 siblings, 1 reply; 12+ messages in thread
From: Nikolay Aleksandrov @ 2026-09-03  8:18 UTC (permalink / raw)
  To: Hangbin Liu, Jay Vosburgh, Andrew Lunn, David S. Miller,
	Eric Dumazet, Jakub Kicinski, Paolo Abeni, Daniel Borkmann,
	Jussi Maki
  Cc: netdev, linux-kernel, Hangbin Liu

On 03/09/2026 11:10, Hangbin Liu wrote:
> From: Hangbin Liu <liuhangbin@kylinos.cn>
> 
> When bond_enslave() succeeds up to the XDP setup stage, slave_cnt is
> already incremented. If XDP setup subsequently fails, the error paths
> jump directly to err_sysfs_del, bypassing the slave_cnt decrement.
> 
> This causes slave_cnt to drift upward on each failed enslaving attempt,
> which would lead to unbalanced traffic distribution with round-robin
> mode.
> 
> Fix it by moving the slave_cnt increasement after XDP setup.
> 
> Fixes: 9e2ee5c7e7c3 ("net, bonding: Add XDP support to the bonding driver")
> Signed-off-by: Hangbin Liu <liuhangbin@kylinos.cn>
> ---
> Changes in v2:
> - move the slave_cnt increasement after XDP setup (Nikolay Aleksandrov)
> - balance-xor mode is not affected, not mention it (Nikolay Aleksandrov)
> - Link to v1: https://lore.kernel.org/r/20260902-bond_slave_cnt-v1-1-36e95bf4a6ff@kylinos.cn
> ---
>   drivers/net/bonding/bond_main.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index 947d92a669b6..f3290aee50d1 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -2284,7 +2284,6 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev,
>   		}
>   	}
>   
> -	WRITE_ONCE(bond->slave_cnt, bond->slave_cnt + 1);
>   	netdev_compute_master_upper_features(bond->dev, true);
>   	bond_set_carrier(bond);
>   
> @@ -2339,6 +2338,8 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev,
>   
>   	bond_xdp_set_features(bond_dev);
>   
> +	WRITE_ONCE(bond->slave_cnt, bond->slave_cnt + 1);
> +
>   	slave_info(bond_dev, slave_dev, "Enslaving as %s interface with %s link\n",
>   		   bond_is_active_slave(new_slave) ? "an active" : "a backup",
>   		   new_slave->link != BOND_LINK_DOWN ? "an up" : "a down");
> 
> ---
> base-commit: 70f3995830d3f1e79faa14eb0605914f778feca9
> change-id: 20260807-bond_slave_cnt-88e78c5f0ab9
> 
> Best regards,

Thanks, looks good to me. One minor nit if there's another version - mention
also the WRITE_ONCE() in the commit message or better yet do it in a separate
commit that properly annotates slave_cnt everywhere.

Reviewed-by: Nikolay Aleksandrov <razor@blackwall.org>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH net v2] bonding: fix slave_cnt leak on XDP error paths
  2026-09-03  8:18 ` Nikolay Aleksandrov
@ 2026-09-03  9:27   ` Hangbin Liu
  2026-09-03  9:31     ` Nikolay Aleksandrov
  0 siblings, 1 reply; 12+ messages in thread
From: Hangbin Liu @ 2026-09-03  9:27 UTC (permalink / raw)
  To: Nikolay Aleksandrov
  Cc: Jay Vosburgh, Andrew Lunn, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Daniel Borkmann, Jussi Maki, netdev,
	linux-kernel, Hangbin Liu

On Thu, Sep 03, 2026 at 11:18:32AM +0300, Nikolay Aleksandrov wrote:
> > diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> > index 947d92a669b6..f3290aee50d1 100644
> > --- a/drivers/net/bonding/bond_main.c
> > +++ b/drivers/net/bonding/bond_main.c
> > @@ -2284,7 +2284,6 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev,
> >   		}
> >   	}
> > -	WRITE_ONCE(bond->slave_cnt, bond->slave_cnt + 1);
> >   	netdev_compute_master_upper_features(bond->dev, true);
> >   	bond_set_carrier(bond);
> > @@ -2339,6 +2338,8 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev,
> >   	bond_xdp_set_features(bond_dev);
> > +	WRITE_ONCE(bond->slave_cnt, bond->slave_cnt + 1);
> > +
> >   	slave_info(bond_dev, slave_dev, "Enslaving as %s interface with %s link\n",
> >   		   bond_is_active_slave(new_slave) ? "an active" : "a backup",
> >   		   new_slave->link != BOND_LINK_DOWN ? "an up" : "a down");
> > 
> > ---
> > base-commit: 70f3995830d3f1e79faa14eb0605914f778feca9
> > change-id: 20260807-bond_slave_cnt-88e78c5f0ab9
> > 
> > Best regards,
> 
> Thanks, looks good to me. One minor nit if there's another version - mention
> also the WRITE_ONCE() in the commit message or better yet do it in a separate
> commit that properly annotates slave_cnt everywhere.

The WRITE_ONCE() change is made by Eric's recent fix
bc93419130bb ("net: bonding: annotate lockless writes with WRITE_ONCE()").

Do you mean add a comment for all the slave_cnt usage?

Thanks
Hangbin

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH net v2] bonding: fix slave_cnt leak on XDP error paths
  2026-09-03  9:27   ` Hangbin Liu
@ 2026-09-03  9:31     ` Nikolay Aleksandrov
  0 siblings, 0 replies; 12+ messages in thread
From: Nikolay Aleksandrov @ 2026-09-03  9:31 UTC (permalink / raw)
  To: Hangbin Liu
  Cc: Jay Vosburgh, Andrew Lunn, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Daniel Borkmann, Jussi Maki, netdev,
	linux-kernel, Hangbin Liu

On 03/09/2026 12:27, Hangbin Liu wrote:
> On Thu, Sep 03, 2026 at 11:18:32AM +0300, Nikolay Aleksandrov wrote:
>>> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
>>> index 947d92a669b6..f3290aee50d1 100644
>>> --- a/drivers/net/bonding/bond_main.c
>>> +++ b/drivers/net/bonding/bond_main.c
>>> @@ -2284,7 +2284,6 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev,
>>>    		}
>>>    	}
>>> -	WRITE_ONCE(bond->slave_cnt, bond->slave_cnt + 1);
>>>    	netdev_compute_master_upper_features(bond->dev, true);
>>>    	bond_set_carrier(bond);
>>> @@ -2339,6 +2338,8 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev,
>>>    	bond_xdp_set_features(bond_dev);
>>> +	WRITE_ONCE(bond->slave_cnt, bond->slave_cnt + 1);
>>> +
>>>    	slave_info(bond_dev, slave_dev, "Enslaving as %s interface with %s link\n",
>>>    		   bond_is_active_slave(new_slave) ? "an active" : "a backup",
>>>    		   new_slave->link != BOND_LINK_DOWN ? "an up" : "a down");
>>>
>>> ---
>>> base-commit: 70f3995830d3f1e79faa14eb0605914f778feca9
>>> change-id: 20260807-bond_slave_cnt-88e78c5f0ab9
>>>
>>> Best regards,
>>
>> Thanks, looks good to me. One minor nit if there's another version - mention
>> also the WRITE_ONCE() in the commit message or better yet do it in a separate
>> commit that properly annotates slave_cnt everywhere.
> 
> The WRITE_ONCE() change is made by Eric's recent fix
> bc93419130bb ("net: bonding: annotate lockless writes with WRITE_ONCE()").
> 
> Do you mean add a comment for all the slave_cnt usage?
> 
> Thanks
> Hangbin

Oops, my tree was older, forgot to sync it, my bad.
All looks good.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH net v2] bonding: fix slave_cnt leak on XDP error paths
  2026-09-03  8:10 [PATCH net v2] bonding: fix slave_cnt leak on XDP error paths Hangbin Liu
  2026-09-03  8:18 ` Nikolay Aleksandrov
@ 2026-09-03 10:38 ` Matthieu Baerts
  2026-09-03 11:53   ` Nikolay Aleksandrov
  2026-09-03 16:22   ` Jakub Kicinski
  2026-09-04 14:11 ` [syzbot ci] " syzbot ci
  2 siblings, 2 replies; 12+ messages in thread
From: Matthieu Baerts @ 2026-09-03 10:38 UTC (permalink / raw)
  To: Hangbin Liu
  Cc: netdev, linux-kernel, Hangbin Liu, Jay Vosburgh, Andrew Lunn,
	David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Daniel Borkmann, Jussi Maki, Nikolay Aleksandrov

Hi Hangbin,

On 03/09/2026 10:10, Hangbin Liu wrote:
> From: Hangbin Liu <liuhangbin@kylinos.cn>
> 
> When bond_enslave() succeeds up to the XDP setup stage, slave_cnt is
> already incremented. If XDP setup subsequently fails, the error paths
> jump directly to err_sysfs_del, bypassing the slave_cnt decrement.
> 
> This causes slave_cnt to drift upward on each failed enslaving attempt,
> which would lead to unbalanced traffic distribution with round-robin
> mode.
> 
> Fix it by moving the slave_cnt increasement after XDP setup.
Thank you for the fix, but it looks like it causes multiple KASAN
issues, see:

 - https://netdev.bots.linux.dev/flakes.html?ld-remote=virt-bonding-dbg

 -
https://netdev.bots.linux.dev/branch_deltas/net-next-2026-09-03--09-00.html

e.g.


https://lore.kernel.org/netdev/20260903-bond_slave_cnt-v2-1-02e27304ca36@kylinos.cn/raw

Cheers,
Matt
-- 
pw-bot: cr


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH net v2] bonding: fix slave_cnt leak on XDP error paths
  2026-09-03 10:38 ` Matthieu Baerts
@ 2026-09-03 11:53   ` Nikolay Aleksandrov
  2026-09-04  1:30     ` Hangbin Liu
                       ` (2 more replies)
  2026-09-03 16:22   ` Jakub Kicinski
  1 sibling, 3 replies; 12+ messages in thread
From: Nikolay Aleksandrov @ 2026-09-03 11:53 UTC (permalink / raw)
  To: Matthieu Baerts, Hangbin Liu
  Cc: netdev, linux-kernel, Hangbin Liu, Jay Vosburgh, Andrew Lunn,
	David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Daniel Borkmann, Jussi Maki

On 03/09/2026 13:38, Matthieu Baerts wrote:
> Hi Hangbin,
> 
> On 03/09/2026 10:10, Hangbin Liu wrote:
>> From: Hangbin Liu <liuhangbin@kylinos.cn>
>>
>> When bond_enslave() succeeds up to the XDP setup stage, slave_cnt is
>> already incremented. If XDP setup subsequently fails, the error paths
>> jump directly to err_sysfs_del, bypassing the slave_cnt decrement.
>>
>> This causes slave_cnt to drift upward on each failed enslaving attempt,
>> which would lead to unbalanced traffic distribution with round-robin
>> mode.
>>
>> Fix it by moving the slave_cnt increasement after XDP setup.
> Thank you for the fix, but it looks like it causes multiple KASAN
> issues, see:
> 
>   - https://netdev.bots.linux.dev/flakes.html?ld-remote=virt-bonding-dbg
> 
>   -
> https://netdev.bots.linux.dev/branch_deltas/net-next-2026-09-03--09-00.html
> 
> e.g.
> 
> 
> https://lore.kernel.org/netdev/20260903-bond_slave_cnt-v2-1-02e27304ca36@kylinos.cn/raw
> 
> Cheers,
> Matt

Waaait a second, it is moved after slave arr update, yes that would cause those.
I missed it in the review, in my suggestion I specifically said it must be before
the slave array update because it uses slave_cnt.

It must be moved up. :)

Thanks,
  Nik


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH net v2] bonding: fix slave_cnt leak on XDP error paths
  2026-09-03 10:38 ` Matthieu Baerts
  2026-09-03 11:53   ` Nikolay Aleksandrov
@ 2026-09-03 16:22   ` Jakub Kicinski
  2026-09-04  2:01     ` Hangbin Liu
  1 sibling, 1 reply; 12+ messages in thread
From: Jakub Kicinski @ 2026-09-03 16:22 UTC (permalink / raw)
  To: Hangbin Liu
  Cc: Matthieu Baerts, netdev, linux-kernel, Hangbin Liu, Jay Vosburgh,
	Andrew Lunn, David S. Miller, Eric Dumazet, Paolo Abeni,
	Daniel Borkmann, Jussi Maki, Nikolay Aleksandrov

On Thu, 3 Sep 2026 12:38:14 +0200 Matthieu Baerts wrote:
> On 03/09/2026 10:10, Hangbin Liu wrote:
> > From: Hangbin Liu <liuhangbin@kylinos.cn>
> > 
> > When bond_enslave() succeeds up to the XDP setup stage, slave_cnt is
> > already incremented. If XDP setup subsequently fails, the error paths
> > jump directly to err_sysfs_del, bypassing the slave_cnt decrement.
> > 
> > This causes slave_cnt to drift upward on each failed enslaving attempt,
> > which would lead to unbalanced traffic distribution with round-robin
> > mode.
> > 
> > Fix it by moving the slave_cnt increasement after XDP setup.  
> Thank you for the fix, but it looks like it causes multiple KASAN
> issues, see:
> 
>  - https://netdev.bots.linux.dev/flakes.html?ld-remote=virt-bonding-dbg

Hangbin, this is at least the 3rd time in a week when kernel selftests
find issues in patches you posted. It's really time for you to run
these tests locally.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH net v2] bonding: fix slave_cnt leak on XDP error paths
  2026-09-03 11:53   ` Nikolay Aleksandrov
@ 2026-09-04  1:30     ` Hangbin Liu
  2026-09-04  1:40     ` Hangbin Liu
  2026-09-04  1:58     ` Hangbin Liu
  2 siblings, 0 replies; 12+ messages in thread
From: Hangbin Liu @ 2026-09-04  1:30 UTC (permalink / raw)
  To: Nikolay Aleksandrov
  Cc: Matthieu Baerts, netdev, linux-kernel, Hangbin Liu, Jay Vosburgh,
	Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Daniel Borkmann, Jussi Maki

On Thu, Sep 03, 2026 at 02:53:29PM +0300, Nikolay Aleksandrov wrote:
> Waaait a second, it is moved after slave arr update, yes that would cause those.
> I missed it in the review, in my suggestion I specifically said it must be before
> the slave array update because it uses slave_cnt.
> 
> It must be moved up. :)

Ah, bond_update_slave_arr()... I only notice the bond_xdp_set_features() and
thought all the code after netdev_ops->ndo_bpf are xdp related...

My bad, I should check the code more carefully, and do testings even with
simple change.

Hangbin

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH net v2] bonding: fix slave_cnt leak on XDP error paths
  2026-09-03 11:53   ` Nikolay Aleksandrov
  2026-09-04  1:30     ` Hangbin Liu
@ 2026-09-04  1:40     ` Hangbin Liu
  2026-09-04  1:58     ` Hangbin Liu
  2 siblings, 0 replies; 12+ messages in thread
From: Hangbin Liu @ 2026-09-04  1:40 UTC (permalink / raw)
  To: Nikolay Aleksandrov
  Cc: Matthieu Baerts, netdev, linux-kernel, Hangbin Liu, Jay Vosburgh,
	Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Daniel Borkmann, Jussi Maki

On Thu, Sep 03, 2026 at 02:53:29PM +0300, Nikolay Aleksandrov wrote:
> > Thank you for the fix, but it looks like it causes multiple KASAN
> > issues, see:
> > 
> >   - https://netdev.bots.linux.dev/flakes.html?ld-remote=virt-bonding-dbg
> > 
> >   -
> > https://netdev.bots.linux.dev/branch_deltas/net-next-2026-09-03--09-00.html
> > 
> > e.g.
> > 
> > 
> > https://lore.kernel.org/netdev/20260903-bond_slave_cnt-v2-1-02e27304ca36@kylinos.cn/raw
> > 
> > Cheers,
> > Matt
> 
> Waaait a second, it is moved after slave arr update, yes that would cause those.
> I missed it in the review, in my suggestion I specifically said it must be before
> the slave array update because it uses slave_cnt.
> 
> It must be moved up. :)
> 

Ah, I thought all the code between netdev_ops->ndo_bpf and
bond_xdp_set_features() are xdp stuff and missed the bond_update_slave_arr()
in the middle...

I need more careful when go though the code and do testing even with simplest
change.

Thanks
Hangbin

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH net v2] bonding: fix slave_cnt leak on XDP error paths
  2026-09-03 11:53   ` Nikolay Aleksandrov
  2026-09-04  1:30     ` Hangbin Liu
  2026-09-04  1:40     ` Hangbin Liu
@ 2026-09-04  1:58     ` Hangbin Liu
  2 siblings, 0 replies; 12+ messages in thread
From: Hangbin Liu @ 2026-09-04  1:58 UTC (permalink / raw)
  To: Nikolay Aleksandrov
  Cc: Matthieu Baerts, netdev, linux-kernel, Hangbin Liu, Jay Vosburgh,
	Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Daniel Borkmann, Jussi Maki

On Thu, Sep 03, 2026 at 02:53:29PM +0300, Nikolay Aleksandrov wrote:
> Waaait a second, it is moved after slave arr update, yes that would cause those.
> I missed it in the review, in my suggestion I specifically said it must be before
> the slave array update because it uses slave_cnt.
> 
> It must be moved up. :)

Ah, I thought all the code between netdev_ops->ndo_bpf and
bond_xdp_set_features() are xdp stuff and missed the bond_update_slave_arr()
in the middle...

I need more careful when go though the code and do testing even with simplest
change.

Thanks
Hangbin

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH net v2] bonding: fix slave_cnt leak on XDP error paths
  2026-09-03 16:22   ` Jakub Kicinski
@ 2026-09-04  2:01     ` Hangbin Liu
  0 siblings, 0 replies; 12+ messages in thread
From: Hangbin Liu @ 2026-09-04  2:01 UTC (permalink / raw)
  To: Jakub Kicinski
  Cc: Matthieu Baerts, netdev, linux-kernel, Hangbin Liu, Jay Vosburgh,
	Andrew Lunn, David S. Miller, Eric Dumazet, Paolo Abeni,
	Daniel Borkmann, Jussi Maki, Nikolay Aleksandrov

On Thu, Sep 03, 2026 at 09:22:58AM -0700, Jakub Kicinski wrote:
> On Thu, 3 Sep 2026 12:38:14 +0200 Matthieu Baerts wrote:
> > On 03/09/2026 10:10, Hangbin Liu wrote:
> > > From: Hangbin Liu <liuhangbin@kylinos.cn>
> > > 
> > > When bond_enslave() succeeds up to the XDP setup stage, slave_cnt is
> > > already incremented. If XDP setup subsequently fails, the error paths
> > > jump directly to err_sysfs_del, bypassing the slave_cnt decrement.
> > > 
> > > This causes slave_cnt to drift upward on each failed enslaving attempt,
> > > which would lead to unbalanced traffic distribution with round-robin
> > > mode.
> > > 
> > > Fix it by moving the slave_cnt increasement after XDP setup.  
> > Thank you for the fix, but it looks like it causes multiple KASAN
> > issues, see:
> > 
> >  - https://netdev.bots.linux.dev/flakes.html?ld-remote=virt-bonding-dbg
> 
> Hangbin, this is at least the 3rd time in a week when kernel selftests
> find issues in patches you posted. It's really time for you to run
> these tests locally.

Yes, you are right. I need to setup local NIPA ASAP. And I will not post
patch before run all related tests on debug kernel.

Sincerely sorry for the trouble this has caused you.

Regards
Hangbin

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [syzbot ci] Re: bonding: fix slave_cnt leak on XDP error paths
  2026-09-03  8:10 [PATCH net v2] bonding: fix slave_cnt leak on XDP error paths Hangbin Liu
  2026-09-03  8:18 ` Nikolay Aleksandrov
  2026-09-03 10:38 ` Matthieu Baerts
@ 2026-09-04 14:11 ` syzbot ci
  2 siblings, 0 replies; 12+ messages in thread
From: syzbot ci @ 2026-09-04 14:11 UTC (permalink / raw)
  To: andrew, daniel, davem, edumazet, hangbin.liu, joamaki, jv, kuba,
	linux-kernel, liuhangbin, netdev, pabeni, razor
  Cc: syzbot, syzkaller-bugs

syzbot ci has tested the following series

[v2] bonding: fix slave_cnt leak on XDP error paths
https://lore.kernel.org/all/20260903-bond_slave_cnt-v2-1-02e27304ca36@kylinos.cn
* [PATCH net v2] bonding: fix slave_cnt leak on XDP error paths

and found the following issue:
KASAN: slab-out-of-bounds Write in bond_update_slave_arr

Full report is available here:
https://ci.syzbot.org/series/f9a94005-1c91-4312-a91e-f495ce00314a

***

KASAN: slab-out-of-bounds Write in bond_update_slave_arr

tree:      linux-next
URL:       https://kernel.googlesource.com/pub/scm/linux/kernel/git/next/linux-next
base:      70f3995830d3f1e79faa14eb0605914f778feca9
arch:      amd64
compiler:  Debian clang version 22.1.8 (++20260613092233+e80beda6e255-1~exp1~20260613092250.77), Debian LLD 22.1.8
config:    https://ci.syzbot.org/builds/767af4fc-83f9-4b54-8f38-27761606a652/config
syz repro: https://ci.syzbot.org/findings/abcea6f7-092c-48e4-8137-756a0ff617ba/syz_repro

8021q: adding VLAN 0 to HW filter on device bond0
bond1: (slave bond0): making interface the new active one
=====
==================================================================
BUG: KASAN: slab-out-of-bounds in bond_update_slave_arr+0x47c/0xf30 drivers/net/bonding/bond_main.c:5198
Write of size 8 at addr ffff888115edcc98 by task syz.1.18/5855

CPU: 1 UID: 0 PID: 5855 Comm: syz.1.18 Not tainted syzkaller #0 PREEMPT(full) 
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120
 print_address_description+0x55/0x1e0 mm/kasan/report.c:378
 print_report+0x58/0x70 mm/kasan/report.c:482
 kasan_report+0x117/0x150 mm/kasan/report.c:595
 bond_update_slave_arr+0x47c/0xf30 drivers/net/bonding/bond_main.c:5198
 bond_enslave+0x2c43/0x3b20 drivers/net/bonding/bond_main.c:2337
 do_set_master+0x563/0x720 net/core/rtnetlink.c:3071
 do_setlink+0xe7b/0x4670 net/core/rtnetlink.c:3273
 rtnl_changelink net/core/rtnetlink.c:3905 [inline]
 __rtnl_newlink net/core/rtnetlink.c:4076 [inline]
 rtnl_newlink+0x15a3/0x1c30 net/core/rtnetlink.c:4215
 rtnetlink_rcv_msg+0x802/0xc00 net/core/rtnetlink.c:7132
 netlink_rcv_skb+0x226/0x4a0 net/netlink/af_netlink.c:2556
 netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline]
 netlink_unicast+0x7bd/0x940 net/netlink/af_netlink.c:1345
 netlink_sendmsg+0x813/0xb40 net/netlink/af_netlink.c:1900
 sock_sendmsg_nosec+0x13a/0x180 net/socket.c:800
 __sock_sendmsg net/socket.c:815 [inline]
 ____sys_sendmsg+0x54e/0x850 net/socket.c:2713
 ___sys_sendmsg+0x2a5/0x360 net/socket.c:2767
 __sys_sendmsg net/socket.c:2799 [inline]
 __do_sys_sendmsg net/socket.c:2804 [inline]
 __se_sys_sendmsg net/socket.c:2802 [inline]
 __x64_sys_sendmsg+0x1b1/0x290 net/socket.c:2802
 do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
 do_syscall_64+0x166/0x520 arch/x86/entry/syscall_64.c:84
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f5f8df9e159
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f5f8ee80028 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007f5f8e225fa0 RCX: 00007f5f8df9e159
RDX: 0000000000000000 RSI: 0000200000000240 RDI: 0000000000000006
RBP: 00007f5f8e035024 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f5f8e226038 R14: 00007f5f8e225fa0 R15: 00007ffd4eafc2e8
 </TASK>

Allocated by task 5855:
 kasan_save_stack mm/kasan/common.c:57 [inline]
 kasan_save_track+0x3e/0x80 mm/kasan/common.c:78
 poison_kmalloc_redzone mm/kasan/common.c:398 [inline]
 __kasan_kmalloc+0x93/0xb0 mm/kasan/common.c:415
 kasan_kmalloc include/linux/kasan.h:263 [inline]
 __do_kmalloc_node mm/slub.c:5414 [inline]
 __kmalloc_noprof+0x36b/0x720 mm/slub.c:5439
 _kmalloc_noprof include/linux/slab.h:995 [inline]
 _kzalloc_noprof include/linux/slab.h:1312 [inline]
 bond_update_slave_arr+0x161/0xf30 drivers/net/bonding/bond_main.c:5172
 bond_enslave+0x2c43/0x3b20 drivers/net/bonding/bond_main.c:2337
 do_set_master+0x563/0x720 net/core/rtnetlink.c:3071
 do_setlink+0xe7b/0x4670 net/core/rtnetlink.c:3273
 rtnl_changelink net/core/rtnetlink.c:3905 [inline]
 __rtnl_newlink net/core/rtnetlink.c:4076 [inline]
 rtnl_newlink+0x15a3/0x1c30 net/core/rtnetlink.c:4215
 rtnetlink_rcv_msg+0x802/0xc00 net/core/rtnetlink.c:7132
 netlink_rcv_skb+0x226/0x4a0 net/netlink/af_netlink.c:2556
 netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline]
 netlink_unicast+0x7bd/0x940 net/netlink/af_netlink.c:1345
 netlink_sendmsg+0x813/0xb40 net/netlink/af_netlink.c:1900
 sock_sendmsg_nosec+0x13a/0x180 net/socket.c:800
 __sock_sendmsg net/socket.c:815 [inline]
 ____sys_sendmsg+0x54e/0x850 net/socket.c:2713
 ___sys_sendmsg+0x2a5/0x360 net/socket.c:2767
 __sys_sendmsg net/socket.c:2799 [inline]
 __do_sys_sendmsg net/socket.c:2804 [inline]
 __se_sys_sendmsg net/socket.c:2802 [inline]
 __x64_sys_sendmsg+0x1b1/0x290 net/socket.c:2802
 do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
 do_syscall_64+0x166/0x520 arch/x86/entry/syscall_64.c:84
 entry_SYSCALL_64_after_hwframe+0x77/0x7f

The buggy address belongs to the object at ffff888115edcc80
 which belongs to the cache kmalloc-32 of size 32
The buggy address is located 0 bytes to the right of
 allocated 24-byte region [ffff888115edcc80, ffff888115edcc98)

The buggy address belongs to the physical page:
page: refcount:0 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x115edc
flags: 0x17ff00000000000(node=0|zone=2|lastcpupid=0x7ff)
page_type: f5(slab)
raw: 017ff00000000000 ffff888100041780 dead000000000100 dead000000000122
raw: 0000000000000000 0000000000400040 00000000f5000000 0000000000000000
page dumped because: kasan: bad access detected
page_owner tracks the page as allocated
page last allocated via order 0, migratetype Unmovable, gfp_mask 0xd2cc0(GFP_KERNEL|__GFP_NOWARN|__GFP_NORETRY|__GFP_COMP|__GFP_NOMEMALLOC), pid 5643, tgid 5643 (syz-executor), ts 53054509528
 set_page_owner include/linux/page_owner.h:33 [inline]
 post_alloc_hook+0x1f9/0x250 mm/page_alloc.c:1871
 prep_new_page mm/page_alloc.c:1879 [inline]
 get_page_from_freelist+0x2209/0x2280 mm/page_alloc.c:3943
 __alloc_frozen_pages_noprof+0x217/0x5a0 mm/page_alloc.c:5436
 alloc_slab_page mm/slub.c:3347 [inline]
 allocate_slab+0x7d/0x620 mm/slub.c:3462
 new_slab mm/slub.c:3513 [inline]
 refill_objects+0x2d5/0x350 mm/slub.c:7410
 refill_sheaf mm/slub.c:2885 [inline]
 __pcs_replace_empty_main+0x2c8/0x6c0 mm/slub.c:4774
 alloc_from_pcs mm/slub.c:4850 [inline]
 slab_alloc_node mm/slub.c:4984 [inline]
 __do_kmalloc_node mm/slub.c:5413 [inline]
 __kmalloc_noprof+0x47b/0x720 mm/slub.c:5439
 _kmalloc_noprof include/linux/slab.h:995 [inline]
 _kzalloc_noprof include/linux/slab.h:1312 [inline]
 lsm_blob_alloc security/security.c:218 [inline]
 lsm_sock_alloc security/security.c:4477 [inline]
 security_sk_alloc+0x52/0x360 security/security.c:4493
 sk_prot_alloc+0x101/0x210 net/core/sock.c:2254
 sk_alloc+0x3a/0x390 net/core/sock.c:2307
 inet6_create+0x81a/0x1270 net/ipv6/af_inet6.c:178
 __sock_create+0x4b3/0x9d0 net/socket.c:1676
 inet_ctl_sock_create+0xa2/0x220 net/ipv4/af_inet.c:1639
 ndisc_net_init+0x95/0x260 net/ipv6/ndisc.c:1977
 ops_init+0x35d/0x5d0 net/core/net_namespace.c:137
 setup_net+0x118/0x350 net/core/net_namespace.c:443
page last free pid 15 tgid 15 ts 53012061369 stack trace:
 reset_page_owner include/linux/page_owner.h:26 [inline]
 __free_pages_prepare mm/page_alloc.c:1418 [inline]
 __free_frozen_pages+0xc93/0xd90 mm/page_alloc.c:2962
 __tlb_remove_table_free mm/mmu_gather.c:228 [inline]
 tlb_remove_table_rcu+0x85/0x100 mm/mmu_gather.c:291
 rcu_do_batch kernel/rcu/tree.c:2650 [inline]
 rcu_core+0x926/0x1260 kernel/rcu/tree.c:2919
 handle_softirqs+0x226/0x860 kernel/softirq.c:645
 run_ksoftirqd+0x36/0x60 kernel/softirq.c:1108
 smpboot_thread_fn+0x565/0xa70 kernel/smpboot.c:160
 kthread+0x38b/0x480 kernel/kthread.c:436
 ret_from_fork+0x514/0xb70 arch/x86/kernel/process.c:158
 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245

Memory state around the buggy address:
 ffff888115edcb80: fa fb fb fb fc fc fc fc fa fb fb fb fc fc fc fc
 ffff888115edcc00: fa fb fb fb fc fc fc fc fa fb fb fb fc fc fc fc
>ffff888115edcc80: 00 00 00 fc fc fc fc fc 00 00 00 fc fc fc fc fc
                            ^
 ffff888115edcd00: 00 00 00 00 fc fc fc fc 00 00 00 fc fc fc fc fc
 ffff888115edcd80: fa fb fb fb fc fc fc fc 00 00 00 fc fc fc fc fc
==================================================================


***

If these findings have caused you to resend the series or submit a
separate fix, please add the following tag to your commit message:
  Tested-by: syzbot@syzkaller.appspotmail.com

---
This report is generated by a bot. It may contain errors.
syzbot ci engineers can be reached at syzkaller@googlegroups.com.

To test a fix for this bug, please reply with `#syz test`
(on a separate line) and attach the patch to the email.

Notes:
- The patch will be applied on top of the tested series (as an
  incremental fix).
- To test a new version of the whole series, please send it directly
  to syzbot@lists.linux.dev.
- Arguments like custom git repos and branches are not supported.

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2026-09-04 14:11 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-03  8:10 [PATCH net v2] bonding: fix slave_cnt leak on XDP error paths Hangbin Liu
2026-09-03  8:18 ` Nikolay Aleksandrov
2026-09-03  9:27   ` Hangbin Liu
2026-09-03  9:31     ` Nikolay Aleksandrov
2026-09-03 10:38 ` Matthieu Baerts
2026-09-03 11:53   ` Nikolay Aleksandrov
2026-09-04  1:30     ` Hangbin Liu
2026-09-04  1:40     ` Hangbin Liu
2026-09-04  1:58     ` Hangbin Liu
2026-09-03 16:22   ` Jakub Kicinski
2026-09-04  2:01     ` Hangbin Liu
2026-09-04 14:11 ` [syzbot ci] " syzbot ci

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox