* [PATCH net] net/mlx5: Fix a NULL vs IS_ERR() check
@ 2023-11-03 6:36 Dan Carpenter
2023-11-03 9:51 ` Wojciech Drewek
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2023-11-03 6:36 UTC (permalink / raw)
To: Saeed Mahameed
Cc: Leon Romanovsky, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Eli Cohen, netdev, linux-rdma, kernel-janitors
The mlx5_esw_offloads_devlink_port() function returns error pointers, not
NULL.
Fixes: 7bef147a6ab6 ("net/mlx5: Don't skip vport check")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
I *think* these normally go through the mellanox tree and not net.
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
index 693e55b010d9..5c569d4bfd00 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
@@ -1493,7 +1493,7 @@ mlx5e_vport_vf_rep_load(struct mlx5_core_dev *dev, struct mlx5_eswitch_rep *rep)
dl_port = mlx5_esw_offloads_devlink_port(dev->priv.eswitch,
rpriv->rep->vport);
- if (dl_port) {
+ if (!IS_ERR(dl_port)) {
SET_NETDEV_DEVLINK_PORT(netdev, dl_port);
mlx5e_rep_vnic_reporter_create(priv, dl_port);
}
--
2.42.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net] net/mlx5: Fix a NULL vs IS_ERR() check
2023-11-03 6:36 [PATCH net] net/mlx5: Fix a NULL vs IS_ERR() check Dan Carpenter
@ 2023-11-03 9:51 ` Wojciech Drewek
0 siblings, 0 replies; 2+ messages in thread
From: Wojciech Drewek @ 2023-11-03 9:51 UTC (permalink / raw)
To: Dan Carpenter, Saeed Mahameed
Cc: Leon Romanovsky, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Eli Cohen, netdev, linux-rdma, kernel-janitors
On 03.11.2023 07:36, Dan Carpenter wrote:
> The mlx5_esw_offloads_devlink_port() function returns error pointers, not
> NULL.
>
> Fixes: 7bef147a6ab6 ("net/mlx5: Don't skip vport check")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> I *think* these normally go through the mellanox tree and not net.
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
>
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
> index 693e55b010d9..5c569d4bfd00 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
> @@ -1493,7 +1493,7 @@ mlx5e_vport_vf_rep_load(struct mlx5_core_dev *dev, struct mlx5_eswitch_rep *rep)
>
> dl_port = mlx5_esw_offloads_devlink_port(dev->priv.eswitch,
> rpriv->rep->vport);
> - if (dl_port) {
> + if (!IS_ERR(dl_port)) {
> SET_NETDEV_DEVLINK_PORT(netdev, dl_port);
> mlx5e_rep_vnic_reporter_create(priv, dl_port);
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-03 9:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-03 6:36 [PATCH net] net/mlx5: Fix a NULL vs IS_ERR() check Dan Carpenter
2023-11-03 9:51 ` Wojciech Drewek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox