Netdev List
 help / color / mirror / Atom feed
* [PATCH net] test_bpf: fix incorrect netdev features
@ 2022-06-22 13:50 Jian Shen
  2022-06-23  1:32 ` John Fastabend
  2022-06-23  2:30 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Jian Shen @ 2022-06-22 13:50 UTC (permalink / raw)
  To: daniel, shmulik; +Cc: bpf, netdev, linuxarm

The prototype of .features is netdev_features_t, it should use
NETIF_F_LLTX and NETIF_F_HW_VLAN_STAG_TX, not NETIF_F_LLTX_BIT
and NETIF_F_HW_VLAN_STAG_TX_BIT.

Fixes: cf204a718357 ("test_bpf: Introduce 'gso_linear_no_head_frag' skb_segment test")

Signed-off-by: Jian Shen <shenjian15@huawei.com>
---
 lib/test_bpf.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/test_bpf.c b/lib/test_bpf.c
index 2a7836e115b4..5820704165a6 100644
--- a/lib/test_bpf.c
+++ b/lib/test_bpf.c
@@ -14733,9 +14733,9 @@ static struct skb_segment_test skb_segment_tests[] __initconst = {
 		.build_skb = build_test_skb_linear_no_head_frag,
 		.features = NETIF_F_SG | NETIF_F_FRAGLIST |
 			    NETIF_F_HW_VLAN_CTAG_TX | NETIF_F_GSO |
-			    NETIF_F_LLTX_BIT | NETIF_F_GRO |
+			    NETIF_F_LLTX | NETIF_F_GRO |
 			    NETIF_F_IPV6_CSUM | NETIF_F_RXCSUM |
-			    NETIF_F_HW_VLAN_STAG_TX_BIT
+			    NETIF_F_HW_VLAN_STAG_TX
 	}
 };
 
-- 
2.33.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [PATCH net] test_bpf: fix incorrect netdev features
  2022-06-22 13:50 [PATCH net] test_bpf: fix incorrect netdev features Jian Shen
@ 2022-06-23  1:32 ` John Fastabend
  2022-06-23  2:30 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: John Fastabend @ 2022-06-23  1:32 UTC (permalink / raw)
  To: Jian Shen, daniel, shmulik; +Cc: bpf, netdev, linuxarm

Jian Shen wrote:
> The prototype of .features is netdev_features_t, it should use
> NETIF_F_LLTX and NETIF_F_HW_VLAN_STAG_TX, not NETIF_F_LLTX_BIT
> and NETIF_F_HW_VLAN_STAG_TX_BIT.
> 
> Fixes: cf204a718357 ("test_bpf: Introduce 'gso_linear_no_head_frag' skb_segment test")
> 
> Signed-off-by: Jian Shen <shenjian15@huawei.com>
> ---

Acked-by: John Fastabend <john.fastabend@gmail.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net] test_bpf: fix incorrect netdev features
  2022-06-22 13:50 [PATCH net] test_bpf: fix incorrect netdev features Jian Shen
  2022-06-23  1:32 ` John Fastabend
@ 2022-06-23  2:30 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-06-23  2:30 UTC (permalink / raw)
  To: Jian Shen; +Cc: daniel, shmulik, bpf, netdev, linuxarm

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:

On Wed, 22 Jun 2022 21:50:02 +0800 you wrote:
> The prototype of .features is netdev_features_t, it should use
> NETIF_F_LLTX and NETIF_F_HW_VLAN_STAG_TX, not NETIF_F_LLTX_BIT
> and NETIF_F_HW_VLAN_STAG_TX_BIT.
> 
> Fixes: cf204a718357 ("test_bpf: Introduce 'gso_linear_no_head_frag' skb_segment test")
> 
> Signed-off-by: Jian Shen <shenjian15@huawei.com>
> 
> [...]

Here is the summary with links:
  - [net] test_bpf: fix incorrect netdev features
    https://git.kernel.org/bpf/bpf-next/c/9676feccacdb

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-06-23  2:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-22 13:50 [PATCH net] test_bpf: fix incorrect netdev features Jian Shen
2022-06-23  1:32 ` John Fastabend
2022-06-23  2:30 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox