[PATCH net v2] net: phy: DP83TC811: add reading of abilities

[PATCH net v2] net: phy: DP83TC811: add reading of abilities

[Sven Schuchmann]

At this time the driver is not listing any speeds
it supports. This should be ETHTOOL_LINK_MODE_100baseT1_Full_BIT
for DP83TC811. Add the missing call for phylib to read the abilities.

v2:
 - Fixed subject and added fixes tag. no code changes.

Fixes: b753a9faaf9a ("net: phy: DP83TC811: Introduce support for the DP83TC811 phy")
Suggested-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Sven Schuchmann <schuchmann@schleissheimer.de>
---
 drivers/net/phy/dp83tc811.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/phy/dp83tc811.c b/drivers/net/phy/dp83tc811.c
index e480c2a07450..6492b60d1f7d 100644
--- a/drivers/net/phy/dp83tc811.c
+++ b/drivers/net/phy/dp83tc811.c
@@ -392,6 +392,7 @@ static struct phy_driver dp83811_driver[] = {
                 /* PHY_BASIC_FEATURES */
                 .config_init = dp83811_config_init,
                 .config_aneg = dp83811_config_aneg,
+               .get_features = genphy_c45_pma_read_ext_abilities,
                 .soft_reset = dp83811_phy_reset,
                 .get_wol = dp83811_get_wol,
                 .set_wol = dp83811_set_wol,
--
2.43.0

Re: [PATCH net v2] net: phy: DP83TC811: add reading of abilities

[Andrew Lunn]

> +++ b/drivers/net/phy/dp83tc811.c
> @@ -392,6 +392,7 @@ static struct phy_driver dp83811_driver[] = {
>                  /* PHY_BASIC_FEATURES */
>                  .config_init = dp83811_config_init,
>                  .config_aneg = dp83811_config_aneg,
> +               .get_features = genphy_c45_pma_read_ext_abilities,
>                  .soft_reset = dp83811_phy_reset,

It looks like there is a space vs tab issue here. It is not just this
one line, but the whole patch. That usually means your email client or
email server has corrupted the email. Ah, outlook.com. Yes, that would
do it.

As a result the patch does not apply and the CI/CD system has not been
able to test your patch.

https://patchwork.kernel.org/project/netdevbpf/patch/BEZP281MB2245C0B534D1297363EE1343D9382@BEZP281MB2245.DEUP281.PROD.OUTLOOK.COM/

One option is to use a web submission endpoint:

https://b4.docs.kernel.org/en/latest/contributor/send.html

Yep, a lot of hoops to jump through, just to get a patch
submitted. The processes are designed to be scalable, handle lots of
patches efficiently. But they are not so friendly to beginners trying
to get one patch merged.

   Andrew