From: Daniel Borkmann <daniel@iogearbox.net>
To: "Daniel T. Lee" <danieltimlee@gmail.com>,
Alexei Starovoitov <ast@kernel.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH V2] samples: bpf: fix: broken sample regarding removed function
Date: Wed, 27 Feb 2019 17:38:18 +0100 [thread overview]
Message-ID: <63f9b3e9-e14d-8ca2-d679-11aac2e4ac8d@iogearbox.net> (raw)
In-Reply-To: <20190227075226.4409-1-danieltimlee@gmail.com>
On 02/27/2019 08:52 AM, Daniel T. Lee wrote:
> Currently, running sample "task_fd_query" and "tracex3" occurs the
> following error. On kernel v5.0-rc* this sample will be unavailable
> due to the removal of function 'blk_start_request' at commit "a1ce35f".
> (function removed, as "Single Queue IO scheduler" no longer exists)
>
> $ sudo ./task_fd_query
> failed to create kprobe 'blk_start_request' error 'No such file or
> directory'
>
> This commit will change the function 'blk_start_request' to
> 'blk_mq_start_request' to fix the broken sample.
>
> Signed-off-by: Daniel T. Lee <danieltimlee@gmail.com>
Applied, thanks! (Also please make sure to test your changes in future
ahead of submission to save valuable reviewer time.)
prev parent reply other threads:[~2019-02-27 16:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 7:52 [PATCH V2] samples: bpf: fix: broken sample regarding removed function Daniel T. Lee
2019-02-27 16:38 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63f9b3e9-e14d-8ca2-d679-11aac2e4ac8d@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=danieltimlee@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox