From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Ziyang Xuan <william.xuanziyang@huawei.com>,
davem@davemloft.net, dsahern@kernel.org, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org
Subject: RE: [PATCH net v2] ipv4: Fix potential uninit variable access buf in __ip_make_skb()
Date: Wed, 19 Apr 2023 10:02:07 -0400 [thread overview]
Message-ID: <643ff45fa94df_3834752945f@willemb.c.googlers.com.notmuch> (raw)
In-Reply-To: <20230410014526.4035442-1-william.xuanziyang@huawei.com>
Ziyang Xuan wrote:
> Like commit ea30388baebc ("ipv6: Fix an uninit variable access bug in
> __ip6_make_skb()"). icmphdr does not in skb linear region under the
> scenario of SOCK_RAW socket. Access icmp_hdr(skb)->type directly will
> trigger the uninit variable access bug.
>
> Use a local variable icmp_type to carry the correct value in different
> scenarios.
>
> Fixes: 96793b482540 ("[IPV4]: Add ICMPMsgStats MIB (RFC 4293)")
> Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
prev parent reply other threads:[~2023-04-19 14:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 1:45 [PATCH net v2] ipv4: Fix potential uninit variable access buf in __ip_make_skb() Ziyang Xuan
2023-04-10 14:30 ` Willem de Bruijn
2023-04-11 9:39 ` Ziyang Xuan (William)
2023-04-18 12:58 ` Ziyang Xuan (William)
2023-04-18 14:28 ` Willem de Bruijn
2023-04-19 9:41 ` Ziyang Xuan (William)
2023-04-19 14:02 ` Willem de Bruijn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=643ff45fa94df_3834752945f@willemb.c.googlers.com.notmuch \
--to=willemdebruijn.kernel@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=william.xuanziyang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox