Re: [PATCH net-next 8/8] net: qualcomm: add QCA7000 UART driver

[Stefan Wahren <stefan.wahren@i2se.com>]

Hi Marcel,

Am 20.09.2016 um 17:32 schrieb Marcel Holtmann:
> Hi Stefan,
>
>> This patch adds the Ethernet over UART driver for the
>> Qualcomm QCA7000 HomePlug GreenPHY.
>>
>> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
>> ---
>> drivers/net/ethernet/qualcomm/Kconfig      |  12 +
>> drivers/net/ethernet/qualcomm/Makefile     |   2 +
>> drivers/net/ethernet/qualcomm/qca_common.h |   6 +
>> drivers/net/ethernet/qualcomm/qca_uart.c   | 447 +++++++++++++++++++++++++++++
>> include/uapi/linux/tty.h                   |   1 +
>> 5 files changed, 468 insertions(+)
>> create mode 100644 drivers/net/ethernet/qualcomm/qca_uart.c
>>
>> diff --git a/drivers/net/ethernet/qualcomm/Kconfig b/drivers/net/ethernet/qualcomm/Kconfig
>> index 0d33728..0ede46e 100644
>> --- a/drivers/net/ethernet/qualcomm/Kconfig
>> +++ b/drivers/net/ethernet/qualcomm/Kconfig
>> @@ -30,6 +30,18 @@ config QCA7000_SPI
>> 	  To compile this driver as a module, choose M here. The module
>> 	  will be called qcaspi.
>>
>> +config QCA7000_UART
>> +	tristate "Qualcomm Atheros QCA7000 UART support"
>> +	select QCA7000
>> +	depends on TTY
>> +	---help---
>> +	  This UART protocol driver supports the Qualcomm Atheros QCA7000.
>> +	  The driver implements the tty line discipline N_QCA7K and supports
>> +	  only one netdevice.
>> +
>> +	  To compile this driver as a module, choose M here. The module
>> +	  will be called qcauart.
>> +
> this seems to be another candidate for having a proper UART or serial bus. Instead of adding one line discipline after another, I think we need to get quickly to having an enumerable bus here.

i noticed Rob's thread about the UART slave device bus and i like the idea.

Stefan

>
> Regards
>
> Marcel
>