From: Andrew Lunn <andrew@lunn.ch>
To: Inochi Amaoto <inochiama@gmail.com>
Cc: Chen Wang <unicorn_wang@outlook.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Inochi Amaoto <inochiama@outlook.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Richard Cochran <richardcochran@gmail.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Yixun Lan <dlan@gentoo.org>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH 4/4] net: stmmac: Add glue layer for Sophgo SG2044 SoC
Date: Mon, 21 Oct 2024 15:27:18 +0200 [thread overview]
Message-ID: <65720a16-d165-4379-a01f-54340fb907df@lunn.ch> (raw)
In-Reply-To: <gwtiuotmwj2x3d5rhfrploj7o763yjye4jj7vniomv77s7crqx@5jwrpwrlwn4s>
> It is related to the RGMII delay. On sg2044, when the phy
> sets rx-delay, the interal mac is not set the same delay,
> so this is needed to be set.
This is the wrong way to do it. Please look at how phy-mode should be
used, the four different "rgmii" values. Nearly everybody gets this
wrong, so there are plenty of emails from me in the netdev list about
how it should be done.
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2024-10-21 13:27 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 10:36 [PATCH 0/4] riscv: sophgo: Add ethernet support for SG2044 Inochi Amaoto
2024-10-21 10:36 ` [PATCH 1/4] dt-bindings: net: snps,dwmac: Add dwmac-5.30a version Inochi Amaoto
2024-10-21 10:36 ` [PATCH 2/4] dt-bindings: net: Add support for Sophgo SG2044 dwmac Inochi Amaoto
2024-10-22 17:28 ` Conor Dooley
2024-10-23 0:31 ` Inochi Amaoto
2024-10-23 20:49 ` Conor Dooley
2024-10-23 22:38 ` Inochi Amaoto
2024-10-24 17:04 ` Conor Dooley
2024-10-24 22:27 ` Inochi Amaoto
2024-10-23 23:41 ` Emil Renner Berthing
2024-10-24 5:08 ` Inochi Amaoto
2024-10-21 10:36 ` [PATCH 3/4] net: stmmac: platform: Add snps,dwmac-5.30a IP compatible string Inochi Amaoto
2024-10-21 10:36 ` [PATCH 4/4] net: stmmac: Add glue layer for Sophgo SG2044 SoC Inochi Amaoto
2024-10-21 12:22 ` Andrew Lunn
2024-10-21 12:38 ` Inochi Amaoto
2024-10-21 13:27 ` Andrew Lunn [this message]
2024-10-22 10:21 ` Inochi Amaoto
2024-10-22 13:51 ` Andrew Lunn
2024-10-23 0:41 ` Inochi Amaoto
2024-10-23 1:08 ` Andrew Lunn
2024-10-23 7:21 ` Inochi Amaoto
2024-10-23 12:42 ` Andrew Lunn
2024-10-23 22:36 ` Inochi Amaoto
2024-10-23 23:56 ` Andrew Lunn
2024-10-22 0:47 ` Chen Wang
2024-10-22 11:04 ` kernel test robot
2024-10-24 15:37 ` Uwe Kleine-König
2024-10-25 1:39 ` Inochi Amaoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65720a16-d165-4379-a01f-54340fb907df@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=edumazet@google.com \
--cc=inochiama@gmail.com \
--cc=inochiama@outlook.com \
--cc=joabreu@synopsys.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=peppe.cavallaro@st.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox