Netdev List
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Colin King <colin.king@canonical.com>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: make hw_err static, reduces object code size
Date: Fri, 25 Jan 2019 08:54:39 +0100	[thread overview]
Message-ID: <6F6742C3-1D20-44F9-9EF6-DF6085069DA0@holtmann.org> (raw)
In-Reply-To: <20190124172254.13186-1-colin.king@canonical.com>

Hi Colin,

> Don't populate the const array hw_err on the stack but instead make
> it static. Makes the object code smaller by 45 bytes:
> 
> Before:
>   text	   data	    bss	    dec	    hex	filename
> 100880	  21090	   1088	 123058	  1e0b2	linux/net/bluetooth/hci_core.o
> 
> After:
>   text	   data	    bss	    dec	    hex	filename
> 100739	  21186	   1088	 123013	  1e085	linux/net/bluetooth/hci_core.o
> 
> (gcc version 8.2.0 x86_64)
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> net/bluetooth/hci_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel


      reply	other threads:[~2019-01-25  7:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-24 17:22 [PATCH] Bluetooth: make hw_err static, reduces object code size Colin King
2019-01-25  7:54 ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6F6742C3-1D20-44F9-9EF6-DF6085069DA0@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=colin.king@canonical.com \
    --cc=davem@davemloft.net \
    --cc=johan.hedberg@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox