From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jie Luo <quic_luoj@quicinc.com>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, andrew@lunn.ch, hkallweit1@gmail.com,
linux@armlinux.org.uk, robert.marko@sartura.hr
Cc: linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_srichara@quicinc.com
Subject: Re: [PATCH v3 5/5] dt-bindings: net: ipq4019-mdio: Document ipq5332 platform
Date: Fri, 15 Dec 2023 13:14:38 +0100 [thread overview]
Message-ID: <6acecb29-2a6c-40af-a5a3-bec3e7286df7@linaro.org> (raw)
In-Reply-To: <f16dfe78-2e31-45fb-b2fe-f72b7e6c51a5@quicinc.com>
On 15/12/2023 13:03, Jie Luo wrote:
>>> If i do not declare the property "reset-assert-us" and
>>> "reset-deassert-us", the warning will be reported by "make
>>> dt_binding_check" since i
>>> add a example in this file.
>>
>> This argument does not make sense, sorry. Obviously if property is not
>> allowed, it should be removed.
>>
>> Provide rationale, in terms of hardware, why this property must be added
>> and why it cannot be deduced from the compatible.
>>
>> Best regards,
>> Krzysztof
>>
>
> So i can remove "reset-assert-us" and "reset-deassert-us" from the added
> example to avoid the dt check warning? even these two properties are
> needed to be defined in the device tree to make this driver working
> correctly.
Sorry, that does not answer my question at all. First, "Driver" is not
hardware. My second question was simply ignored. In the v2 thread you as
well respond with some short, unrelated sentences not answering to the
real questions. It's a waste of my time. Please reach internally in
Qualcomm for guidance how to upstream patches and how to write bindings.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-15 12:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 9:02 [PATCH v3 0/5] support ipq5332 platform Luo Jie
2023-12-14 9:03 ` [PATCH v3 1/5] net: mdio: ipq4019: move eth_ldo_rdy before MDIO bus register Luo Jie
2023-12-14 9:03 ` [PATCH v3 2/5] net: mdio: ipq4019: enable the SoC uniphy clocks for ipq5332 platform Luo Jie
2023-12-14 9:03 ` [PATCH v3 3/5] net: mdio: ipq4019: configure CMN PLL clock for ipq5332 Luo Jie
2023-12-14 9:03 ` [PATCH v3 4/5] net: mdio: ipq4019: support MDIO clock frequency divider Luo Jie
2023-12-14 9:03 ` [PATCH v3 5/5] dt-bindings: net: ipq4019-mdio: Document ipq5332 platform Luo Jie
2023-12-14 15:58 ` Conor Dooley
2023-12-15 6:49 ` Jie Luo
2023-12-15 7:27 ` Krzysztof Kozlowski
2023-12-15 8:28 ` Jie Luo
2023-12-15 8:39 ` Krzysztof Kozlowski
2023-12-15 10:03 ` Jie Luo
2023-12-15 10:21 ` Krzysztof Kozlowski
2023-12-15 12:03 ` Jie Luo
2023-12-15 12:14 ` Krzysztof Kozlowski [this message]
2023-12-15 12:55 ` Jie Luo
2023-12-15 13:34 ` Andrew Lunn
2023-12-16 13:23 ` Jie Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6acecb29-2a6c-40af-a5a3-bec3e7286df7@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_luoj@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=robert.marko@sartura.hr \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox