Netdev List
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Felix Fietkau <nbd@nbd.name>, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: bridge: do not send arp replies if src and target hw addr is the same
Date: Tue, 09 Jan 2024 12:36:06 +0100	[thread overview]
Message-ID: <6b43ec63a2bbb91e78f7ea7954f6d5148a33df00.camel@redhat.com> (raw)
In-Reply-To: <20240104142501.81092-1-nbd@nbd.name>

On Thu, 2024-01-04 at 15:25 +0100, Felix Fietkau wrote:
> There are broken devices in the wild that handle duplicate IP address
> detection by sending out ARP requests for the IP that they received from a
> DHCP server and refuse the address if they get a reply.
> When proxyarp is enabled, they would go into a loop of requesting an address
> and then NAKing it again.

Can you instead provide the same functionality with some nft/tc
ingress/ebpf filter?

I feel uneasy to hard code this kind of policy, even if it looks
sensible. I suspect it could break some other currently working weird
device behavior.

Otherwise it could be nice provide some arpfilter flag to
enable/disable this kind filtering.

Cheers,

Paolo


  reply	other threads:[~2024-01-09 11:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-04 14:25 [PATCH net-next] net: bridge: do not send arp replies if src and target hw addr is the same Felix Fietkau
2024-01-09 11:36 ` Paolo Abeni [this message]
2024-01-09 11:58   ` Felix Fietkau
2024-01-09 12:02     ` Nikolay Aleksandrov
2024-01-09 12:41       ` Felix Fietkau
2024-01-09 12:14     ` Paolo Abeni
2024-01-09 12:18       ` Nikolay Aleksandrov
2024-01-09 12:49 ` Dave Taht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6b43ec63a2bbb91e78f7ea7954f6d5148a33df00.camel@redhat.com \
    --to=pabeni@redhat.com \
    --cc=nbd@nbd.name \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox