public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Kai Lueke <kailueke@linux.microsoft.com>
To: Jakub Kicinski <kuba@kernel.org>,
	Steffen Klassert <steffen.klassert@secunet.com>
Cc: Paul Chaignon <paul@cilium.io>,
	Eyal Birger <eyal.birger@gmail.com>,
	netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] Revert "xfrm: interface with if_id 0 should return error"
Date: Wed, 2 Mar 2022 19:11:06 +0100	[thread overview]
Message-ID: <6c2d3e6b-23f8-d4a4-4701-ff9288c18a5c@linux.microsoft.com> (raw)
In-Reply-To: <20220302080439.2324c5d0@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>

Hi,
> Agreed. FWIW would be great if patch #2 started flowing towards Linus'es
> tree separately if the discussion on #1 is taking longer.

to preserve the initial goal of helping to uncover id 0 usage I think it
would be best to have the revert be accompanied by a patch that instead
creates a kernel log warning (or whatever).

Since I never did that I suggest to not wait for me.
Also, feel free to do the revert yourself with a different commit
message if mine didn't capture the things appropriately.

Regards,
Kai


  reply	other threads:[~2022-03-02 18:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-01 13:15 [PATCH 1/2] Revert "xfrm: interface with if_id 0 should return error" kailueke
2022-03-01 13:15 ` [PATCH 2/2] Revert "xfrm: state and policy should fail if XFRMA_IF_ID 0" kailueke
2022-03-01 13:28 ` [PATCH 1/2] Revert "xfrm: interface with if_id 0 should return error" Eyal Birger
2022-03-01 14:17   ` Kai Lüke
2022-03-01 14:34     ` Eyal Birger
2022-03-01 15:09       ` Paul Chaignon
2022-03-01 15:48         ` Kai Lüke
2022-03-01 16:10           ` Steffen Klassert
2022-03-01 16:44             ` Kai Lueke
2022-03-02  9:27               ` Nicolas Dichtel
2022-03-02 16:04             ` Jakub Kicinski
2022-03-02 18:11               ` Kai Lueke [this message]
2022-03-03  5:33                 ` Jakub Kicinski
2022-03-03  7:54                   ` Steffen Klassert
  -- strict thread matches above, loose matches on Subject: below --
2022-02-28 18:55 Kai Lüke
2022-02-28 18:51 Kai Lüke
2022-02-28 18:49 Kai Lüke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c2d3e6b-23f8-d4a4-4701-ff9288c18a5c@linux.microsoft.com \
    --to=kailueke@linux.microsoft.com \
    --cc=eyal.birger@gmail.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=paul@cilium.io \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox