From: Igor Russkikh <igor.russkikh@aquantia.com>
To: Yanko Kaneti <yaneti@declera.com>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: aquantia - BUG: unable to handle kernel NULL pointer dereference at 0000000000000058 on reboot
Date: Tue, 10 Apr 2018 15:53:39 +0300 [thread overview]
Message-ID: <6df8b628-cec5-9ce5-8430-e9a2cd27346d@aquantia.com> (raw)
In-Reply-To: <5a5882e07351e92a5d57ea6d1b91fcab55e466bf.camel@declera.com>
On 10.04.2018 15:42, Yanko Kaneti wrote:
> Hello,
>
> Since 90869ddfefeb net: aquantia: Implement pci shutdown callback
> I get the below oops on reboot. Without the callback everything works
> as expected.
>
Thanks, we also recently found out that.
Could you please try the below patch?
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
index c96a921..32f6d2e 100644
--- a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
+++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
@@ -951,9 +951,11 @@ void aq_nic_shutdown(struct aq_nic_s *self)
netif_device_detach(self->ndev);
- err = aq_nic_stop(self);
- if (err < 0)
- goto err_exit;
+ if (netif_running(self->ndev)) {
+ err = aq_nic_stop(self);
+ if (err < 0)
+ goto err_exit;
+ }
aq_nic_deinit(self);
err_exit:
--
2.7.4
next prev parent reply other threads:[~2018-04-10 12:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 12:42 aquantia - BUG: unable to handle kernel NULL pointer dereference at 0000000000000058 on reboot Yanko Kaneti
2018-04-10 12:53 ` Igor Russkikh [this message]
2018-04-10 14:06 ` Yanko Kaneti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6df8b628-cec5-9ce5-8430-e9a2cd27346d@aquantia.com \
--to=igor.russkikh@aquantia.com \
--cc=netdev@vger.kernel.org \
--cc=yaneti@declera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox