[PATCH net v2 0/3] net: freescale: fix PTP_EXTTS_REQUEST2 for QorIQ 1588

[PATCH net v2 0/3] net: freescale: fix PTP_EXTTS_REQUEST2 for QorIQ 1588

[Vincent Jardin via B4 Relay]

Since commit 7c571ac57d9d ("net: ptp: introduce .supported_extts_flags
to ptp_clock_info"), the PTP core rejects every PTP_EXTTS_REQUEST2
request for a driver that does not set .supported_extts_flags. The three
users of the QorIQ 1588 timer (dpaa2-ptp, enetc, ptp_qoriq) do not set
it, so linuxptp ts2phc cannot arm their external timestamp inputs.

The timer timestamps the rising edge only, since ptp_qoriq_init() clears
ETEP1 and ETEP2. Each patch declares PTP_RISING_EDGE | PTP_STRICT_FLAGS
for one driver.

With PTP_STRICT_FLAGS declared, the core checks the edge flags of the
legacy PTP_EXTTS_REQUEST ioctl too: a legacy request for the falling
edge, or for both edges, now fails with -EOPNOTSUPP instead of being
timestamped on the rising edge. Each commit message says so.

Patch 1 fixes the failure seen on an LX2160A board.
Patches 2 and 3 are build-tested/code review only.

Signed-off-by: Vincent Jardin <vjardin@free.fr>
---
Changes in v2:
- add comments about PTP_EXTTS_REQUEST (Sashiko)
- Name other users of ptp_qoriq_init() in each commit message (Sashiko)
- Add Reviewed-by tags of Jacob and Kory, the code is unchanged, only
  commit log improvements.
- Link to v1: https://lore.kernel.org/r/20261006-for-upstream-qoriq-ptp-extts-flags-v1-0-b4a161b92832@free.fr

---
Vincent Jardin (3):
      dpaa2-ptp: fix support for PTP_EXTTS_REQUEST2 ioctl
      net: enetc: fix support for PTP_EXTTS_REQUEST2 ioctl
      ptp: qoriq: fix support for PTP_EXTTS_REQUEST2 ioctl

 drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c | 1 +
 drivers/net/ethernet/freescale/enetc/enetc_ptp.c | 1 +
 drivers/ptp/ptp_qoriq.c                          | 1 +
 3 files changed, 3 insertions(+)
---
base-commit: d5a007b9b457c915ab1a53227e8939e4018aa97a
change-id: 20261006-for-upstream-qoriq-ptp-extts-flags-1c6fd731d66f

Best regards,
-- 
Vincent Jardin <vjardin@free.fr>

[PATCH net v2 1/3] dpaa2-ptp: fix support for PTP_EXTTS_REQUEST2 ioctl

[Vincent Jardin via B4 Relay]

From: Vincent Jardin <vjardin@free.fr>

Commit 7c571ac57d9d ("net: ptp: introduce .supported_extts_flags to
ptp_clock_info") moved the validation of the external timestamp request
flags into the PTP core. A driver that does not set
.supported_extts_flags still accepts the legacy PTP_EXTTS_REQUEST ioctl,
but every PTP_EXTTS_REQUEST2 request is rejected with -EOPNOTSUPP.

On an LX2160A board, linuxptp ts2phc arms the external timestamp channel
of the 1588 timer with PTP_EXTTS_REQUEST2, gets -EOPNOTSUPP and exits,
so the PHC cannot be disciplined from an external 1PPS.

ptp_qoriq_init() programs TMR_CTRL with ETEP1 and ETEP2 cleared, so the
timer timestamps the rising edge of its external trigger inputs. Declare
that, with PTP_STRICT_FLAGS, so that a falling edge request is rejected
instead of being timestamped on the rising edge.

This also makes the legacy PTP_EXTTS_REQUEST ioctl strict: a request for
the falling edge, or for both edges, now fails with -EOPNOTSUPP instead
of being timestamped on the rising edge. That cannot be avoided: the core
adds PTP_STRICT_FLAGS to every PTP_EXTTS_REQUEST2 request, so a driver
has to declare it to accept them, and once declared it applies to both
ioctls. Commit 3200fdd4021d ("broadcom: fix support for
PTP_EXTTS_REQUEST2 ioctl") made the same change for bcm-phy-ptp.

Fixes: 7c571ac57d9d ("net: ptp: introduce .supported_extts_flags to ptp_clock_info")
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Kory Maincent <kory.maincent@bootlin.com>
Signed-off-by: Vincent Jardin <vjardin@free.fr>
---
 drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c
index 4497e3c0456d..ac2b873dcf8e 100644
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c
@@ -78,6 +78,7 @@ static const struct ptp_clock_info dpaa2_ptp_caps = {
 	.n_per_out	= 3,
 	.n_pins		= 0,
 	.pps		= 1,
+	.supported_extts_flags = PTP_RISING_EDGE | PTP_STRICT_FLAGS,
 	.adjfine	= ptp_qoriq_adjfine,
 	.adjtime	= ptp_qoriq_adjtime,
 	.gettime64	= ptp_qoriq_gettime,

-- 
2.43.0

[PATCH net v2 2/3] net: enetc: fix support for PTP_EXTTS_REQUEST2 ioctl

[Vincent Jardin via B4 Relay]

From: Vincent Jardin <vjardin@free.fr>

Commit 7c571ac57d9d ("net: ptp: introduce .supported_extts_flags to
ptp_clock_info") moved the validation of the external timestamp request
flags into the PTP core. A driver that does not set
.supported_extts_flags still accepts the legacy PTP_EXTTS_REQUEST ioctl,
but every PTP_EXTTS_REQUEST2 request is rejected with -EOPNOTSUPP.

The ENETC timer is the QorIQ 1588 timer, set up by ptp_qoriq_init(), which
programs TMR_CTRL with ETEP1 and ETEP2 cleared, so it timestamps the
rising edge of its external trigger inputs. Declare that, with
PTP_STRICT_FLAGS, so that a falling edge request is rejected instead of
being timestamped on the rising edge.

This also makes the legacy PTP_EXTTS_REQUEST ioctl strict: a request for
the falling edge, or for both edges, now fails with -EOPNOTSUPP instead
of being timestamped on the rising edge. That cannot be avoided: the core
adds PTP_STRICT_FLAGS to every PTP_EXTTS_REQUEST2 request, so a driver
has to declare it to accept them, and once declared it applies to both
ioctls. Commit 3200fdd4021d ("broadcom: fix support for
PTP_EXTTS_REQUEST2 ioctl") made the same change for bcm-phy-ptp.

Fixes: 7c571ac57d9d ("net: ptp: introduce .supported_extts_flags to ptp_clock_info")
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Kory Maincent <kory.maincent@bootlin.com>
Signed-off-by: Vincent Jardin <vjardin@free.fr>
---
 drivers/net/ethernet/freescale/enetc/enetc_ptp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/freescale/enetc/enetc_ptp.c b/drivers/net/ethernet/freescale/enetc/enetc_ptp.c
index 162cbc801730..5ffee882d624 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc_ptp.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc_ptp.c
@@ -16,6 +16,7 @@ static struct ptp_clock_info enetc_ptp_caps = {
 	.n_per_out	= 0,
 	.n_pins		= 0,
 	.pps		= 1,
+	.supported_extts_flags = PTP_RISING_EDGE | PTP_STRICT_FLAGS,
 	.adjfine	= ptp_qoriq_adjfine,
 	.adjtime	= ptp_qoriq_adjtime,
 	.gettime64	= ptp_qoriq_gettime,

-- 
2.43.0

RE: [PATCH net v2 2/3] net: enetc: fix support for PTP_EXTTS_REQUEST2 ioctl

[Wei Fang]

> Commit 7c571ac57d9d ("net: ptp: introduce .supported_extts_flags to
> ptp_clock_info") moved the validation of the external timestamp request
> flags into the PTP core. A driver that does not set
> .supported_extts_flags still accepts the legacy PTP_EXTTS_REQUEST ioctl,
> but every PTP_EXTTS_REQUEST2 request is rejected with -EOPNOTSUPP.
> 
> The ENETC timer is the QorIQ 1588 timer, set up by ptp_qoriq_init(), which
> programs TMR_CTRL with ETEP1 and ETEP2 cleared, so it timestamps the
> rising edge of its external trigger inputs. Declare that, with
> PTP_STRICT_FLAGS, so that a falling edge request is rejected instead of
> being timestamped on the rising edge.
> 
> This also makes the legacy PTP_EXTTS_REQUEST ioctl strict: a request for
> the falling edge, or for both edges, now fails with -EOPNOTSUPP instead
> of being timestamped on the rising edge. That cannot be avoided: the core
> adds PTP_STRICT_FLAGS to every PTP_EXTTS_REQUEST2 request, so a driver
> has to declare it to accept them, and once declared it applies to both
> ioctls. Commit 3200fdd4021d ("broadcom: fix support for
> PTP_EXTTS_REQUEST2 ioctl") made the same change for bcm-phy-ptp.
> 
> Fixes: 7c571ac57d9d ("net: ptp: introduce .supported_extts_flags to
> ptp_clock_info")
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> Reviewed-by: Kory Maincent <kory.maincent@bootlin.com>
> Signed-off-by: Vincent Jardin <vjardin@free.fr>
> ---
>  drivers/net/ethernet/freescale/enetc/enetc_ptp.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/freescale/enetc/enetc_ptp.c
> b/drivers/net/ethernet/freescale/enetc/enetc_ptp.c
> index 162cbc801730..5ffee882d624 100644
> --- a/drivers/net/ethernet/freescale/enetc/enetc_ptp.c
> +++ b/drivers/net/ethernet/freescale/enetc/enetc_ptp.c
> @@ -16,6 +16,7 @@ static struct ptp_clock_info enetc_ptp_caps = {
>  	.n_per_out	= 0,
>  	.n_pins		= 0,
>  	.pps		= 1,
> +	.supported_extts_flags = PTP_RISING_EDGE | PTP_STRICT_FLAGS,
>  	.adjfine	= ptp_qoriq_adjfine,
>  	.adjtime	= ptp_qoriq_adjtime,
>  	.gettime64	= ptp_qoriq_gettime,
> 
> --
> 2.43.0
> 

Reviewed-by: Wei Fang <wei.fang@nxp.com>

[PATCH net v2 3/3] ptp: qoriq: fix support for PTP_EXTTS_REQUEST2 ioctl

[Vincent Jardin via B4 Relay]

From: Vincent Jardin <vjardin@free.fr>

Commit 7c571ac57d9d ("net: ptp: introduce .supported_extts_flags to
ptp_clock_info") moved the validation of the external timestamp request
flags into the PTP core. A driver that does not set
.supported_extts_flags still accepts the legacy PTP_EXTTS_REQUEST ioctl,
but every PTP_EXTTS_REQUEST2 request is rejected with -EOPNOTSUPP, since
the core always adds PTP_STRICT_FLAGS to it.

ptp_qoriq_init() programs TMR_CTRL with ETEP1 and ETEP2 cleared, so the
timer timestamps the rising edge of its external trigger inputs. Declare
that, with PTP_STRICT_FLAGS, so that a falling edge request is rejected
instead of being timestamped on the rising edge.

This also makes the legacy PTP_EXTTS_REQUEST ioctl strict: a request for
the falling edge, or for both edges, now fails with -EOPNOTSUPP instead
of being timestamped on the rising edge. That cannot be avoided: the core
adds PTP_STRICT_FLAGS to every PTP_EXTTS_REQUEST2 request, so a driver
has to declare it to accept them, and once declared it applies to both
ioctls. Commit 3200fdd4021d ("broadcom: fix support for
PTP_EXTTS_REQUEST2 ioctl") made the same change for bcm-phy-ptp.

Fixes: 7c571ac57d9d ("net: ptp: introduce .supported_extts_flags to ptp_clock_info")
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Kory Maincent <kory.maincent@bootlin.com>
Signed-off-by: Vincent Jardin <vjardin@free.fr>
---
 drivers/ptp/ptp_qoriq.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/ptp/ptp_qoriq.c b/drivers/ptp/ptp_qoriq.c
index 76272e5ac5b8..bcd29104effe 100644
--- a/drivers/ptp/ptp_qoriq.c
+++ b/drivers/ptp/ptp_qoriq.c
@@ -355,6 +355,7 @@ static const struct ptp_clock_info ptp_qoriq_caps = {
 	.n_per_out	= 0,
 	.n_pins		= 0,
 	.pps		= 1,
+	.supported_extts_flags = PTP_RISING_EDGE | PTP_STRICT_FLAGS,
 	.adjfine	= ptp_qoriq_adjfine,
 	.adjtime	= ptp_qoriq_adjtime,
 	.gettime64	= ptp_qoriq_gettime,

-- 
2.43.0

RE: [PATCH net v2 3/3] ptp: qoriq: fix support for PTP_EXTTS_REQUEST2 ioctl

[Wei Fang]

> From: Vincent Jardin <vjardin@free.fr>
> 
> Commit 7c571ac57d9d ("net: ptp: introduce .supported_extts_flags to
> ptp_clock_info") moved the validation of the external timestamp request
> flags into the PTP core. A driver that does not set
> .supported_extts_flags still accepts the legacy PTP_EXTTS_REQUEST ioctl,
> but every PTP_EXTTS_REQUEST2 request is rejected with -EOPNOTSUPP, since
> the core always adds PTP_STRICT_FLAGS to it.
> 
> ptp_qoriq_init() programs TMR_CTRL with ETEP1 and ETEP2 cleared, so the
> timer timestamps the rising edge of its external trigger inputs. Declare
> that, with PTP_STRICT_FLAGS, so that a falling edge request is rejected
> instead of being timestamped on the rising edge.
> 
> This also makes the legacy PTP_EXTTS_REQUEST ioctl strict: a request for
> the falling edge, or for both edges, now fails with -EOPNOTSUPP instead
> of being timestamped on the rising edge. That cannot be avoided: the core
> adds PTP_STRICT_FLAGS to every PTP_EXTTS_REQUEST2 request, so a driver
> has to declare it to accept them, and once declared it applies to both
> ioctls. Commit 3200fdd4021d ("broadcom: fix support for
> PTP_EXTTS_REQUEST2 ioctl") made the same change for bcm-phy-ptp.
> 
> Fixes: 7c571ac57d9d ("net: ptp: introduce .supported_extts_flags to
> ptp_clock_info")
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> Reviewed-by: Kory Maincent <kory.maincent@bootlin.com>
> Signed-off-by: Vincent Jardin <vjardin@free.fr>
> ---
>  drivers/ptp/ptp_qoriq.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ptp/ptp_qoriq.c b/drivers/ptp/ptp_qoriq.c
> index 76272e5ac5b8..bcd29104effe 100644
> --- a/drivers/ptp/ptp_qoriq.c
> +++ b/drivers/ptp/ptp_qoriq.c
> @@ -355,6 +355,7 @@ static const struct ptp_clock_info ptp_qoriq_caps = {
>  	.n_per_out	= 0,
>  	.n_pins		= 0,
>  	.pps		= 1,
> +	.supported_extts_flags = PTP_RISING_EDGE | PTP_STRICT_FLAGS,
>  	.adjfine	= ptp_qoriq_adjfine,
>  	.adjtime	= ptp_qoriq_adjtime,
>  	.gettime64	= ptp_qoriq_gettime,
> 
> --
> 2.43.0
> 

Reviewed-by: Wei Fang <wei.fang@nxp.com>

Re: [PATCH net v2 3/3] ptp: qoriq: fix support for PTP_EXTTS_REQUEST2 ioctl

[netdev-bot+sashiko]

Thank you for your contribution! Sashiko AI review found 1 potential
issue(s) to consider.

Critical: 0 · High: 0 · Medium: 1 · Low: 0

If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).

- [Medium] The commit message says that making the legacy
  PTP_EXTTS_REQUEST ioctl strict "cannot be avoided", because the core…

--

ptp: qoriq: fix support for PTP_EXTTS_REQUEST2 ioctl

This patch sets .supported_extts_flags in ptp_qoriq_caps to
PTP_RISING_EDGE | PTP_STRICT_FLAGS, so that the PTP core stops rejecting
every PTP_EXTTS_REQUEST2 request. Because of this, the legacy
PTP_EXTTS_REQUEST ioctl now also rejects falling-edge and both-edge
requests.

> This also makes the legacy PTP_EXTTS_REQUEST ioctl strict: a request for
> the falling edge, or for both edges, now fails with -EOPNOTSUPP instead
> of being timestamped on the rising edge. That cannot be avoided: the core
> adds PTP_STRICT_FLAGS to every PTP_EXTTS_REQUEST2 request, so a driver
> has to declare it to accept them, and once declared it applies to both
> ioctls.

> diff --git a/drivers/ptp/ptp_qoriq.c b/drivers/ptp/ptp_qoriq.c
> index 76272e5ac5b85..bcd29104effe7 100644
> --- a/drivers/ptp/ptp_qoriq.c
> +++ b/drivers/ptp/ptp_qoriq.c
> @@ -355,6 +355,7 @@ static const struct ptp_clock_info ptp_qoriq_caps = {
>  	.n_per_out	= 0,
>  	.n_pins		= 0,
>  	.pps		= 1,
> +	.supported_extts_flags = PTP_RISING_EDGE | PTP_STRICT_FLAGS,

[Severity: Medium]
Is the "cannot be avoided" part of the commit message accurate?

In ptp_extts_request() in drivers/ptp/ptp_chardev.c, the strict bit is
only added for PTP_EXTTS_REQUEST2. For the legacy ioctl it is always
removed by the mask:

drivers/ptp/ptp_chardev.c:ptp_extts_request() {
    ...
	if (cmd == PTP_EXTTS_REQUEST2) {
		/* Tell the drivers to check the flags carefully. */
		req.extts.flags |= PTP_STRICT_FLAGS;
    ...
	} else {
		req.extts.flags &= PTP_EXTTS_V1_VALID_FLAGS;
    ...
}

PTP_EXTTS_V1_VALID_FLAGS contains only ENABLE, RISING and FALLING. The
.enable callback can therefore tell the two ioctls apart by checking
PTP_STRICT_FLAGS in rq->extts.flags.

Drivers in the tree already do this. mv88e6xxx declares
RISING | FALLING | STRICT and rejects the unsupported edge combination
only for strict requests:

drivers/net/dsa/mv88e6xxx/ptp.c:mv88e6352_ptp_enable_extts() {
    ...
	if ((rq->extts.flags & PTP_STRICT_FLAGS) &&
	    (rq->extts.flags & PTP_ENABLE_FEATURE) &&
	    (rq->extts.flags & PTP_EXTTS_EDGES) == PTP_EXTTS_EDGES)
		return -EOPNOTSUPP;
    ...
}

sja1105 does something similar in sja1105_ptp.c.

Could qoriq do the same? It would declare PTP_RISING_EDGE |
PTP_FALLING_EDGE | PTP_STRICT_FLAGS in ptp_qoriq_caps. Then
ptp_qoriq_enable() would return -EOPNOTSUPP when STRICT, ENABLE and
FALLING are all set. That fixes PTP_EXTTS_REQUEST2 and leaves the legacy
ioctl lenient. enetc_ptp.c also uses ptp_qoriq_enable(), so the same
check would cover enetc.

As written, with the Fixes: tag, this is going to stable. Legacy
PTP_EXTTS_REQUEST calls on QorIQ timers that ask for the falling edge or
for both edges now fail with -EOPNOTSUPP. Before this patch they
succeeded and were timestamped on the rising edge. Commit 7c571ac57d9d
calls the legacy edge flags hints that are not expected to be enforced.

testptp hits this path. Running it with -e and -E 2 or -E 3 sends
PTP_EXTTS_REQUEST with PTP_FALLING_EDGE set.

If the stricter legacy behaviour is intended, could the commit message
say that a lenient alternative exists, rather than saying the change
cannot be avoided?

>  	.adjfine	= ptp_qoriq_adjfine,
>  	.adjtime	= ptp_qoriq_adjtime,
>  	.gettime64	= ptp_qoriq_gettime,

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261009-for-upstream-qoriq-ptp-extts-flags-v2-0-0f4eeff2295d%40free.fr

Re: [PATCH net v2 3/3] ptp: qoriq: fix support for PTP_EXTTS_REQUEST2 ioctl

[Jacob Keller]

On 10/11/2026 5:02 PM, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider.
> 
> Critical: 0 · High: 0 · Medium: 1 · Low: 0
> 
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
> 
> - [Medium] The commit message says that making the legacy
>   PTP_EXTTS_REQUEST ioctl strict "cannot be avoided", because the core…
> 
> --
> 
> ptp: qoriq: fix support for PTP_EXTTS_REQUEST2 ioctl
> 
> This patch sets .supported_extts_flags in ptp_qoriq_caps to
> PTP_RISING_EDGE | PTP_STRICT_FLAGS, so that the PTP core stops rejecting
> every PTP_EXTTS_REQUEST2 request. Because of this, the legacy
> PTP_EXTTS_REQUEST ioctl now also rejects falling-edge and both-edge
> requests.
> 
>> This also makes the legacy PTP_EXTTS_REQUEST ioctl strict: a request for
>> the falling edge, or for both edges, now fails with -EOPNOTSUPP instead
>> of being timestamped on the rising edge. That cannot be avoided: the core
>> adds PTP_STRICT_FLAGS to every PTP_EXTTS_REQUEST2 request, so a driver
>> has to declare it to accept them, and once declared it applies to both
>> ioctls.
> 
>> diff --git a/drivers/ptp/ptp_qoriq.c b/drivers/ptp/ptp_qoriq.c
>> index 76272e5ac5b85..bcd29104effe7 100644
>> --- a/drivers/ptp/ptp_qoriq.c
>> +++ b/drivers/ptp/ptp_qoriq.c
>> @@ -355,6 +355,7 @@ static const struct ptp_clock_info ptp_qoriq_caps = {
>>  	.n_per_out	= 0,
>>  	.n_pins		= 0,
>>  	.pps		= 1,
>> +	.supported_extts_flags = PTP_RISING_EDGE | PTP_STRICT_FLAGS,
> 
> [Severity: Medium]
> Is the "cannot be avoided" part of the commit message accurate?
> 
> In ptp_extts_request() in drivers/ptp/ptp_chardev.c, the strict bit is
> only added for PTP_EXTTS_REQUEST2. For the legacy ioctl it is always
> removed by the mask:
> 
> drivers/ptp/ptp_chardev.c:ptp_extts_request() {
>     ...
> 	if (cmd == PTP_EXTTS_REQUEST2) {
> 		/* Tell the drivers to check the flags carefully. */
> 		req.extts.flags |= PTP_STRICT_FLAGS;
>     ...
> 	} else {
> 		req.extts.flags &= PTP_EXTTS_V1_VALID_FLAGS;
>     ...
> }
> 
> PTP_EXTTS_V1_VALID_FLAGS contains only ENABLE, RISING and FALLING. The
> .enable callback can therefore tell the two ioctls apart by checking
> PTP_STRICT_FLAGS in rq->extts.flags.
> 
> Drivers in the tree already do this. mv88e6xxx declares
> RISING | FALLING | STRICT and rejects the unsupported edge combination
> only for strict requests:
> 
> drivers/net/dsa/mv88e6xxx/ptp.c:mv88e6352_ptp_enable_extts() {
>     ...
> 	if ((rq->extts.flags & PTP_STRICT_FLAGS) &&
> 	    (rq->extts.flags & PTP_ENABLE_FEATURE) &&
> 	    (rq->extts.flags & PTP_EXTTS_EDGES) == PTP_EXTTS_EDGES)
> 		return -EOPNOTSUPP;
>     ...
> }
> 
> sja1105 does something similar in sja1105_ptp.c.
> 
> Could qoriq do the same? It would declare PTP_RISING_EDGE |
> PTP_FALLING_EDGE | PTP_STRICT_FLAGS in ptp_qoriq_caps. Then
> ptp_qoriq_enable() would return -EOPNOTSUPP when STRICT, ENABLE and
> FALLING are all set. That fixes PTP_EXTTS_REQUEST2 and leaves the legacy
> ioctl lenient. enetc_ptp.c also uses ptp_qoriq_enable(), so the same
> check would cover enetc.
> 
> As written, with the Fixes: tag, this is going to stable. Legacy
> PTP_EXTTS_REQUEST calls on QorIQ timers that ask for the falling edge or
> for both edges now fail with -EOPNOTSUPP. Before this patch they
> succeeded and were timestamped on the rising edge. Commit 7c571ac57d9d
> calls the legacy edge flags hints that are not expected to be enforced.
> 
> testptp hits this path. Running it with -e and -E 2 or -E 3 sends
> PTP_EXTTS_REQUEST with PTP_FALLING_EDGE set.
> 
> If the stricter legacy behaviour is intended, could the commit message
> say that a lenient alternative exists, rather than saying the change
> cannot be avoided?
> 
Hm. The intended behavior had been that legacy ioctl would remain
supporting the non-strict mode. I guess the way its implemented doesn't
quite work. The strict flag is cleared automatically but only from the
req.extts.flags, and not from supported_extts_flags. I guess that might
be an oversight in the ioctl implementation. Its been a while so I can't
remember the specific reason this version was opted for. We could modify
the core to also allow non-strict mode for legacy ioctls..

I'd prefer not to fix this in the driver as the AI suggests here. Either
we accept that both ioctls will be strict in cases where the requested
mode is not listed, or we need to change the core to work this way.
Having each driver have its own variation of policy was one of the
things I aimed to avoid with my refactor :/

>>  	.adjfine	= ptp_qoriq_adjfine,
>>  	.adjtime	= ptp_qoriq_adjtime,
>>  	.gettime64	= ptp_qoriq_gettime,
>