* [PATCH net-next] net: dsa: Fix inverted test for multiple CPU interface
@ 2017-01-22 21:16 Andrew Lunn
2017-01-23 5:26 ` Florian Fainelli
2017-01-24 18:34 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Andrew Lunn @ 2017-01-22 21:16 UTC (permalink / raw)
To: David Miller; +Cc: Vivien Didelot, Florian Fainelli, netdev, Andrew Lunn
Remove the wrong !, otherwise we get false positives about having
multiple CPU interfaces.
Fixes: b22de490869d ("net: dsa: store CPU switch structure in the tree")
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
net/dsa/dsa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c
index 77cb78767f1d..1f3afeb673d6 100644
--- a/net/dsa/dsa.c
+++ b/net/dsa/dsa.c
@@ -225,7 +225,7 @@ static int dsa_switch_setup_one(struct dsa_switch *ds, struct device *parent)
continue;
if (!strcmp(name, "cpu")) {
- if (!dst->cpu_switch) {
+ if (dst->cpu_switch) {
netdev_err(dst->master_netdev,
"multiple cpu ports?!\n");
return -EINVAL;
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: dsa: Fix inverted test for multiple CPU interface
2017-01-22 21:16 [PATCH net-next] net: dsa: Fix inverted test for multiple CPU interface Andrew Lunn
@ 2017-01-23 5:26 ` Florian Fainelli
2017-01-24 18:34 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2017-01-23 5:26 UTC (permalink / raw)
To: Andrew Lunn, David Miller; +Cc: Vivien Didelot, netdev
On 01/22/2017 01:16 PM, Andrew Lunn wrote:
> Remove the wrong !, otherwise we get false positives about having
> multiple CPU interfaces.
>
> Fixes: b22de490869d ("net: dsa: store CPU switch structure in the tree")
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: dsa: Fix inverted test for multiple CPU interface
2017-01-22 21:16 [PATCH net-next] net: dsa: Fix inverted test for multiple CPU interface Andrew Lunn
2017-01-23 5:26 ` Florian Fainelli
@ 2017-01-24 18:34 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-01-24 18:34 UTC (permalink / raw)
To: andrew; +Cc: vivien.didelot, f.fainelli, netdev
From: Andrew Lunn <andrew@lunn.ch>
Date: Sun, 22 Jan 2017 22:16:45 +0100
> Remove the wrong !, otherwise we get false positives about having
> multiple CPU interfaces.
>
> Fixes: b22de490869d ("net: dsa: store CPU switch structure in the tree")
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-24 18:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-22 21:16 [PATCH net-next] net: dsa: Fix inverted test for multiple CPU interface Andrew Lunn
2017-01-23 5:26 ` Florian Fainelli
2017-01-24 18:34 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox