* [PATCH net-next] net: phy: micrel: use dev_err_probe()
@ 2026-05-15 12:05 Robert Marko
2026-05-15 13:29 ` Andrew Lunn
0 siblings, 1 reply; 2+ messages in thread
From: Robert Marko @ 2026-05-15 12:05 UTC (permalink / raw)
To: andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni, netdev,
linux-kernel
Cc: luka.perkov, Robert Marko
Currently, during probe defferal the driver will print multiple times:
mscc-miim e20101a8.mdio: Cannot register MDIO bus (-517)
So, lets silence that by using the dev_err_probe() for printing the probe
error as it handles probe defferal.
Signed-off-by: Robert Marko <robert.marko@sartura.hr>
---
drivers/net/mdio/mdio-mscc-miim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mdio/mdio-mscc-miim.c b/drivers/net/mdio/mdio-mscc-miim.c
index 944efd33da6d..259944d37fbd 100644
--- a/drivers/net/mdio/mdio-mscc-miim.c
+++ b/drivers/net/mdio/mdio-mscc-miim.c
@@ -330,7 +330,7 @@ static int mscc_miim_probe(struct platform_device *pdev)
ret = of_mdiobus_register(bus, np);
if (ret < 0) {
- dev_err(dev, "Cannot register MDIO bus (%d)\n", ret);
+ dev_err_probe(dev, ret, "Cannot register MDIO bus\n");
goto out_disable_clk;
}
--
2.54.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: phy: micrel: use dev_err_probe()
2026-05-15 12:05 [PATCH net-next] net: phy: micrel: use dev_err_probe() Robert Marko
@ 2026-05-15 13:29 ` Andrew Lunn
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Lunn @ 2026-05-15 13:29 UTC (permalink / raw)
To: Robert Marko
Cc: hkallweit1, linux, davem, edumazet, kuba, pabeni, netdev,
linux-kernel, luka.perkov
On Fri, May 15, 2026 at 02:05:40PM +0200, Robert Marko wrote:
> Currently, during probe defferal the driver will print multiple times:
> mscc-miim e20101a8.mdio: Cannot register MDIO bus (-517)
>
> So, lets silence that by using the dev_err_probe() for printing the probe
> error as it handles probe defferal.
>
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-15 13:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-15 12:05 [PATCH net-next] net: phy: micrel: use dev_err_probe() Robert Marko
2026-05-15 13:29 ` Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox