From: Andrew Lunn <andrew@lunn.ch>
To: POPESCU Catalin <catalin.popescu@leica-geosystems.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"afd@ti.com" <afd@ti.com>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
GEO-CHHER-bsp-development
<bsp-development.geo@leica-geosystems.com>,
"m.felsch@pengutronix.de" <m.felsch@pengutronix.de>
Subject: Re: [PATCH v2 2/2] net: phy: dp83826: support TX data voltage tuning
Date: Thu, 8 Feb 2024 17:50:46 +0100 [thread overview]
Message-ID: <71efc6d3-bef1-4c2e-aa6c-195e26f791dc@lunn.ch> (raw)
In-Reply-To: <68f0b7ce-6c77-41b2-9749-1cd8f72c253d@leica-geosystems.com>
> Now, I understand your question 🙂
> To answer, DP83826_CFG_DAC_MINUS_DEFAULT will indeed leave the register
> unchanged. However, dp83822 driver exports a PHY callback soft_reset
> which does a SW reset which actually has the same effect as the HW reset
> pin according to the datasheet. Since the PAL enforces the call to
> soft_reset before config_init, in dp83826_config_init we can rely on the
> registers reset value.
Great. Please add a version of this to the commit message. That shows
we did our due diligence and we don't expect any surprises in the
future.
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2024-02-08 16:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 17:58 [PATCH v2 1/2] dt-bindings: net: dp83826: support TX data voltage tuning Catalin Popescu
2024-02-07 17:58 ` [PATCH v2 2/2] net: phy: " Catalin Popescu
2024-02-07 18:35 ` Andrew Lunn
2024-02-08 8:58 ` POPESCU Catalin
2024-02-08 13:56 ` Andrew Lunn
2024-02-08 16:14 ` POPESCU Catalin
2024-02-08 16:50 ` Andrew Lunn [this message]
2024-02-08 16:54 ` POPESCU Catalin
2024-02-08 7:35 ` [PATCH v2 1/2] dt-bindings: net: " Krzysztof Kozlowski
2024-02-08 8:48 ` POPESCU Catalin
2024-02-08 8:50 ` Krzysztof Kozlowski
2024-02-08 9:08 ` POPESCU Catalin
2024-02-08 9:12 ` Krzysztof Kozlowski
2024-02-08 9:19 ` POPESCU Catalin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71efc6d3-bef1-4c2e-aa6c-195e26f791dc@lunn.ch \
--to=andrew@lunn.ch \
--cc=afd@ti.com \
--cc=bsp-development.geo@leica-geosystems.com \
--cc=catalin.popescu@leica-geosystems.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.felsch@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox