From: Eric Dumazet <eric.dumazet@gmail.com>
To: f6bvp <f6bvp@free.fr>, netdev@vger.kernel.org
Subject: Re: ax25: fix possible use-after-free
Date: Sun, 17 Feb 2019 10:39:08 -0800 [thread overview]
Message-ID: <73130cb1-4fe8-6079-4e9b-678cb34de9b2@gmail.com> (raw)
In-Reply-To: <20190216233349.7977096b@draws-f6bvp>
On 02/16/2019 02:33 PM, f6bvp wrote:
>
> Patch applied successfully on Linux draws-f6bvp 4.14.79-v7+ #1159 SMP Sun Nov 4 17:50:20 GMT 2018 armv7l GNU/Linux
>
> However ax25_route_lock_use and ax25_route_lock_unuse() are not declared and compile failed.
>
> make : on entre dans le répertoire « /usr/src/linux-headers-4.14.79-v7+ »
> CC [M] /usr/src/linux-4.14.y/net/ax25/ax25_ip.o
> /usr/src/linux-4.14.y/net/ax25/ax25_ip.c: In function ‘ax25_ip_xmit’:
> /usr/src/linux-4.14.y/net/ax25/ax25_ip.c:117:2: error: implicit declaration of function ‘ax25_route_lock_use’ [-Werror=implicit-function-declaration]
> ax25_route_lock_use();
> ^~~~~~~~~~~~~~~~~~~
> /usr/src/linux-4.14.y/net/ax25/ax25_ip.c:211:2: error: implicit declaration of function ‘ax25_route_lock_unuse’ [-Werror=implicit-function-declaration]
> ax25_route_lock_unuse();
> ^~~~~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
> scripts/Makefile.build:328 : la recette pour la cible « /usr/src/linux-4.14.y/net/ax25/ax25_ip.o » a echouee
> make[1]: *** [/usr/src/linux-4.14.y/net/ax25/ax25_ip.o] Erreur 1
> Makefile:1527 : la recette pour la cible « _module_/usr/src/linux-4.14.y/net/ax25 » a echouee
> make: *** [_module_/usr/src/linux-4.14.y/net/ax25] Erreur 2
> make : on quitte le repertoire « /usr/src/linux-headers-4.14.79-v7+ »
>
>
> Bernard, f6bvp
>
Hi Bernard
Are you sure you applied the patch correctly/completely ?
git cherry-pick worked without conflicts on top of 4.14.100
next prev parent reply other threads:[~2019-02-17 18:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-16 22:33 ax25: fix possible use-after-free f6bvp
2019-02-17 18:39 ` Eric Dumazet [this message]
2019-02-17 23:47 ` f6bvp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73130cb1-4fe8-6079-4e9b-678cb34de9b2@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=f6bvp@free.fr \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox