Re: [PATCH net-next v3 0/3] ipv4: Flush the FIB once on multiple nexthop removal

[David Ahern <dsahern@kernel.org>]

On 5/7/26 1:56 AM, Cosmin Ratiu wrote:
> This series optimizes multiple nexthop removal performance from having
> to do a FIB flush for each nexthop being removed to only doing a single
> FIB flush after all nexthops are removed.
> 
> This dramatically improves performance in scenarios where there are
> many nexthops and many ipv4 routes. Please see individual patches for
> more details and for a test scenario.
> 
> V2 -> V3: https://lore.kernel.org/netdev/8fea4084-c9ec-472a-b8ab-ecc87e537216@kernel.org/T/#t
> - Split the patch into 3 (Ido Schimmel, David Ahern)
> - Used WARN_ON_ONCE instead of WARN_ON (Ido Schimmel)
> 
> V1 -> V2:
> - Fixes xmas tree in a couple places (Kuniyuki Iwashima)
> - Added __must_check to remove_nexthop_from_groups() (Kuniyuki Iwashima)
> 
> Cosmin Ratiu (3):
>   ipv4: Provide a FIB flushing signal from nexthop removal functions
>   ipv4: Flush the FIB once on multiple nexthop removal
>   ipv4: Add __must_check to nexthop removal functions
> 
>  net/ipv4/nexthop.c | 88 +++++++++++++++++++++++++++++-----------------
>  1 file changed, 56 insertions(+), 32 deletions(-)
> 

Much easier to follow. Thank you.

For the set:
Reviewed-by: David Ahern <dsahern@kernel.org>