From: David Howells <dhowells@redhat.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: dhowells@redhat.com, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Alexander Duyck <alexanderduyck@fb.com>,
Jesper Dangaard Brouer <brouer@redhat.com>,
Pavel Begunkov <asml.silence@gmail.com>,
Kees Cook <keescook@chromium.org>, Jiri Benc <jbenc@redhat.com>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] net: fix signedness bug in skb_splice_from_iter()
Date: Fri, 26 May 2023 14:17:38 +0100 [thread overview]
Message-ID: <760142.1685107058@warthog.procyon.org.uk> (raw)
In-Reply-To: <99284df8-9190-4deb-ad7c-c0557614a1c8@kili.mountain>
Dan Carpenter <dan.carpenter@linaro.org> wrote:
> while (iter->count > 0) {
> ssize_t space, nr;
> - size_t off, len;
> + ssize_t len;
> + size_t off;
Good point, but why not just move len onto the preceding line?
while (iter->count > 0) {
- ssize_t space, nr;
- size_t off, len;
+ ssize_t space, nr, len;
+ size_t off;
David
next prev parent reply other threads:[~2023-05-26 13:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 11:46 [PATCH net-next] net: fix signedness bug in skb_splice_from_iter() Dan Carpenter
2023-05-26 13:17 ` David Howells [this message]
2023-05-26 13:20 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=760142.1685107058@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=alexanderduyck@fb.com \
--cc=asml.silence@gmail.com \
--cc=brouer@redhat.com \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jbenc@redhat.com \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox