* [PATCH net-next] net: fix signedness bug in skb_splice_from_iter()
@ 2023-05-26 11:46 Dan Carpenter
2023-05-26 13:17 ` David Howells
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2023-05-26 11:46 UTC (permalink / raw)
To: David Howells
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Alexander Duyck, Jesper Dangaard Brouer, Pavel Begunkov,
Kees Cook, Jiri Benc, netdev, kernel-janitors
The "len" variable needs to be signed for the error handling to work
correctly.
Fixes: 2e910b95329c ("net: Add a function to splice pages into an skbuff for MSG_SPLICE_PAGES")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
net/core/skbuff.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 653abd8a6975..57a8ba81ab39 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -6932,7 +6932,8 @@ ssize_t skb_splice_from_iter(struct sk_buff *skb, struct iov_iter *iter,
while (iter->count > 0) {
ssize_t space, nr;
- size_t off, len;
+ ssize_t len;
+ size_t off;
ret = -EMSGSIZE;
space = frag_limit - skb_shinfo(skb)->nr_frags;
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: fix signedness bug in skb_splice_from_iter()
2023-05-26 11:46 [PATCH net-next] net: fix signedness bug in skb_splice_from_iter() Dan Carpenter
@ 2023-05-26 13:17 ` David Howells
2023-05-26 13:20 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: David Howells @ 2023-05-26 13:17 UTC (permalink / raw)
To: Dan Carpenter
Cc: dhowells, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Alexander Duyck, Jesper Dangaard Brouer,
Pavel Begunkov, Kees Cook, Jiri Benc, netdev, kernel-janitors
Dan Carpenter <dan.carpenter@linaro.org> wrote:
> while (iter->count > 0) {
> ssize_t space, nr;
> - size_t off, len;
> + ssize_t len;
> + size_t off;
Good point, but why not just move len onto the preceding line?
while (iter->count > 0) {
- ssize_t space, nr;
- size_t off, len;
+ ssize_t space, nr, len;
+ size_t off;
David
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: fix signedness bug in skb_splice_from_iter()
2023-05-26 13:17 ` David Howells
@ 2023-05-26 13:20 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2023-05-26 13:20 UTC (permalink / raw)
To: David Howells
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Alexander Duyck, Jesper Dangaard Brouer, Pavel Begunkov,
Kees Cook, Jiri Benc, netdev, kernel-janitors
On Fri, May 26, 2023 at 02:17:38PM +0100, David Howells wrote:
> Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> > while (iter->count > 0) {
> > ssize_t space, nr;
> > - size_t off, len;
> > + ssize_t len;
> > + size_t off;
>
> Good point, but why not just move len onto the preceding line?
>
> while (iter->count > 0) {
> - ssize_t space, nr;
> - size_t off, len;
> + ssize_t space, nr, len;
> + size_t off;
Sure. Will do.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-26 13:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-26 11:46 [PATCH net-next] net: fix signedness bug in skb_splice_from_iter() Dan Carpenter
2023-05-26 13:17 ` David Howells
2023-05-26 13:20 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox