[PATCH v3 net-next] net: rnpgbe: Delete a null pointer check in rnpgbe_rm_adapter()

[PATCH v3 net-next] net: rnpgbe: Delete a null pointer check in rnpgbe_rm_adapter()

[Markus Elfring]

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 17 Jul 2026 10:20:15 +0200

The check for the pointer “mucse” was identified as redundant because
the relevant address information was preserved according to calls of
the functions “pci_set_drvdata” and “pci_get_drvdata”.
Thus remove it.

This issue was detected by using the Coccinelle software.

See also:
Reconsidering pointer dereferences before null pointer checks (with SmPL)
2023-04-09
https://lore.kernel.org/cocci/1a11455f-ab57-dce0-1677-6beb8492a257@web.de/
https://sympa.inria.fr/sympa/arc/cocci/2023-04/msg00021.html

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---

v3:
Andrew Lunn and Julia Lawall requested an extended change description.

v2:
Andrew Lunn requested the removal of a null pointer check.


 drivers/net/ethernet/mucse/rnpgbe/rnpgbe_main.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_main.c b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_main.c
index 70a2b0082ba8..82a3fbfb3c0a 100644
--- a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_main.c
+++ b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_main.c
@@ -249,8 +249,6 @@ static void rnpgbe_rm_adapter(struct pci_dev *pdev)
 	struct net_device *netdev;
 	int err;
 
-	if (!mucse)
-		return;
 	netdev = mucse->netdev;
 	unregister_netdev(netdev);
 	err = rnpgbe_send_notify(hw, false, mucse_fw_powerup);
-- 
2.55.0

Re: [PATCH v3 net-next] net: rnpgbe: Delete a null pointer check in rnpgbe_rm_adapter()

[Andrew Lunn]

On Fri, Jul 17, 2026 at 10:38:32AM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 17 Jul 2026 10:20:15 +0200
> 
> The check for the pointer “mucse” was identified as redundant because
> the relevant address information was preserved according to calls of
> the functions “pci_set_drvdata” and “pci_get_drvdata”.
> Thus remove it.
> 
> This issue was detected by using the Coccinelle software.
> 
> See also:
> Reconsidering pointer dereferences before null pointer checks (with SmPL)
> 2023-04-09
> https://lore.kernel.org/cocci/1a11455f-ab57-dce0-1677-6beb8492a257@web.de/
> https://sympa.inria.fr/sympa/arc/cocci/2023-04/msg00021.html
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew