From: "Nazle Asmade, Muhammad Nazim Amirul" <muhammad.nazim.amirul.nazle.asmade@altera.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "dinguyen@kernel.org" <dinguyen@kernel.org>,
"maxime.chevallier@bootlin.com" <maxime.chevallier@bootlin.com>,
"rmk+kernel@armlinux.org.uk" <rmk+kernel@armlinux.org.uk>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 3/4] dt-bindings: net: altr,socfpga-stmmac: Add altr,socfpga-stmmac-agilex5-tsn compatible
Date: Mon, 27 Jul 2026 02:08:55 +0000 [thread overview]
Message-ID: <7b9fe974-4bb6-4b12-98f0-ce6af3a9ceda@altera.com> (raw)
In-Reply-To: <20260716-turtle-of-massive-thunder-be8283@quoll>
On 16/7/2026 3:58 pm, Krzysztof Kozlowski wrote:
> On Wed, Jul 15, 2026 at 07:19:31PM -0700, muhammad.nazim.amirul.nazle.asmade@altera.com wrote:
>> From: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
>>
>> The Agilex5 SoCDK TSN Config2 board uses a GMII-to-RGMII converter
>> implemented as FPGA soft IP between gmac1 and its PHY. This converter
>> provides the RGMII TX/RX clock delays. Document a new compatible string
>> for this MAC variant so the driver can detect it and configure the
>> interface accordingly.
>
> Last sentence is completely redundant. You are not supposed to reference
> drivers here. I even EXPLICITLY marked this with BOLD font (as a common
> mistake) in DTS101 speech.
>
> Explain why devices are or are not compatible. You claim they are
> compatible, but driver still treats them partially incompatible.
Hi Krzysztof,
Thank you for the review.
Understood, we will remove that and rewrite the commit message to
describe the hardware difference only.
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2026-07-27 2:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 2:19 [PATCH v4 0/4] Add Agilex5 SoCDK TSN Config2 board support muhammad.nazim.amirul.nazle.asmade
2026-07-16 2:19 ` [PATCH v4 1/4] dt-bindings: arm: altera: Add Agilex5 SoCDK TSN Config2 board muhammad.nazim.amirul.nazle.asmade
2026-07-16 2:19 ` [PATCH v4 2/4] arm64: dts: socfpga: agilex5: Add " muhammad.nazim.amirul.nazle.asmade
2026-07-16 2:19 ` [PATCH v4 3/4] dt-bindings: net: altr,socfpga-stmmac: Add altr,socfpga-stmmac-agilex5-tsn compatible muhammad.nazim.amirul.nazle.asmade
2026-07-16 7:58 ` Krzysztof Kozlowski
2026-07-27 2:08 ` Nazle Asmade, Muhammad Nazim Amirul [this message]
2026-07-16 2:19 ` [PATCH net-next v4 4/4] net: stmmac: dwmac-socfpga: Add support for Agilex5 TSN GMAC with FPGA converter muhammad.nazim.amirul.nazle.asmade
2026-07-16 7:56 ` Krzysztof Kozlowski
2026-07-27 2:07 ` Nazle Asmade, Muhammad Nazim Amirul
2026-08-11 15:34 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b9fe974-4bb6-4b12-98f0-ce6af3a9ceda@altera.com \
--to=muhammad.nazim.amirul.nazle.asmade@altera.com \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox