Netdev List
 help / color / mirror / Atom feed
From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
Cc: Jacob Keller <jacob.e.keller@intel.com>,
	intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
	anthony.l.nguyen@intel.com
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1] ixgbe: Convert ret val type from s32 to int
Date: Thu, 4 Jan 2024 08:26:16 +0100	[thread overview]
Message-ID: <7bfd7069-8222-4388-bc1f-d4e77093b503@molgen.mpg.de> (raw)
In-Reply-To: <20240103101135.386891-1-jedrzej.jagielski@intel.com>

[Re-sent with diff removed, so message size limit of 90 kB of list 
Intel-wired-lan is met.]

Dear Jedrzej,


Thank you for your patch.

Am 03.01.24 um 11:11 schrieb Jedrzej Jagielski:
> Currently big amount of the functions returning standard
> error codes are of type s32. Convert them to regular
> ints.

Please make use of the full allowed text width of 75 characters per line.

Also please add the motivation. Why are regular ints better?

[…]


Kind regards,

Paul

  parent reply	other threads:[~2024-01-04  7:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-03 10:11 [PATCH iwl-next v1] ixgbe: Convert ret val type from s32 to int Jedrzej Jagielski
2024-01-04  0:27 ` [Intel-wired-lan] " Paul Menzel
2024-01-04  7:26 ` Paul Menzel [this message]
2024-01-04 14:47 ` Dan Carpenter
2024-01-05  7:14   ` Przemek Kitszel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7bfd7069-8222-4388-bc1f-d4e77093b503@molgen.mpg.de \
    --to=pmenzel@molgen.mpg.de \
    --cc=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jacob.e.keller@intel.com \
    --cc=jedrzej.jagielski@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox