From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
netdev@vger.kernel.org
Cc: "moderated list:ETHERNET BRIDGE"
<bridge@lists.linux-foundation.org>,
kernel@savoirfairelinux.com, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [SPAM]Re: [PATCH net-next 5/6] net: bridge: get msgtype from nlmsghdr in mdb ops
Date: Thu, 18 May 2017 20:01:12 +0300 [thread overview]
Message-ID: <7f4c1954-bf78-9160-64d0-ed45cad388e6@cumulusnetworks.com> (raw)
In-Reply-To: <87efvmf9fl.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>
On 5/18/17 6:53 PM, Vivien Didelot wrote:
> Hi Nikolay,
>
> Nikolay Aleksandrov <nikolay@cumulusnetworks.com> writes:
>
>>> + int msgtype = nlh->nlmsg_type;
>>
>> minor nits:
>> nlmsg_type is a u16, also please keep the order and arrange these from longest
>> to shortest
>
> The reverse christmas tree \o/
>
> Hum, __br_mdb_notify takes an int type, and struct nlmsghdr defines it
> as a __u16. Does u16 still make sense here instead of int?
>
>
> Thanks,
>
> Vivien
>
Either way is fine as long as the value is unchanged, and since the rest of
the code uses an int then lets be consistent and leave it or if you decide
change all.
Cheers,
Nik
next prev parent reply other threads:[~2017-05-18 17:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 21:27 [PATCH net-next 0/6] net: bridge: factorize MDB new and del functions Vivien Didelot
2017-05-17 21:27 ` [PATCH net-next 1/6] net: bridge: pass net_bridge_port to __br_mdb_add Vivien Didelot
2017-05-17 21:27 ` [PATCH net-next 2/6] net: bridge: check multicast bridge only once Vivien Didelot
2017-05-17 21:27 ` [PATCH net-next 3/6] net: bridge: break if __br_mdb_del fails Vivien Didelot
2017-05-18 13:45 ` Nikolay Aleksandrov
2017-05-18 15:08 ` Vivien Didelot
2017-05-18 15:25 ` Nikolay Aleksandrov
2017-05-18 15:45 ` Vivien Didelot
2017-05-17 21:27 ` [PATCH net-next 4/6] net: bridge: add __br_mdb_do Vivien Didelot
2017-05-17 21:27 ` [PATCH net-next 5/6] net: bridge: get msgtype from nlmsghdr in mdb ops Vivien Didelot
2017-05-18 15:28 ` Nikolay Aleksandrov
2017-05-18 15:53 ` [SPAM]Re: " Vivien Didelot
2017-05-18 17:01 ` Nikolay Aleksandrov [this message]
2017-05-17 21:27 ` [PATCH net-next 6/6] net: bridge: add br_mdb_do Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f4c1954-bf78-9160-64d0-ed45cad388e6@cumulusnetworks.com \
--to=nikolay@cumulusnetworks.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox