Re: [PATCH v5 net-next 3/3] selftests:net: Implement ptp4l sync test using netdevsim

[Maciek Machnikowski <maciek@machnikowski.net>]

On 06/05/2026 02:23, Jakub Kicinski wrote:
> On Tue, 5 May 2026 17:22:34 -0700 Jakub Kicinski wrote:
>> On Tue, 5 May 2026 09:36:30 +0200 Maciek Machnikowski wrote:
>>> On 04/05/2026 19:07, Jakub Kicinski wrote:  
>>>> On Sun,  3 May 2026 09:47:47 +0200 Maciek Machnikowski wrote:    
>>>> Doesn't seem to pass on netdevsim for us:
>>>>
>>>> # 41.13 [+40.95] # ptp4l follower did not reach locked state (s2) within 40s
>>>> # 41.13 [+0.00] # Follower log (last 10 lines): ptp4l[2179.605]: ioctl SIOCETHTOOL failed: Operation not supported | ptp4l[2179.607]: interface 'eth0' does not support requested timestamping mode | failed to create a clock
>>>> # 41.15 [+0.02] # Check| At /srv/vmksft/testing/wt-2/tools/testing/selftests/net/./ptp.py, line 173, in ptp_sync_test:
>>>> # 41.15 [+0.01] # Check|     _run_ptp4l_wait_sync(nsimsv.ifname, nsimcl.ifname, nssv.name, nscl.name)
>>>> # 41.16 [+0.01] # Check| At /srv/vmksft/testing/wt-2/tools/testing/selftests/net/./ptp.py, line 99, in _run_ptp4l_wait_sync:
>>>> # 41.17 [+0.01] # Check|     ksft_true(False, "PTP sync timeout")
>>>> # 41.17 [+0.00] # Check failed False does not eval to True PTP sync timeout
>>>> # 41.32 [+0.16] not ok 1 ptp.ptp_sync_test
>>>> # 41.33 [+0.00] # Totals: pass:0 fail:1 xfail:0 xpass:0 skip:0 error:0
>>>>
>>>> Anything we need to do?    
>>>
>>> Can you share the config file you used? Seems the PTP clock was not
>>> found which may lead to PTP_1588_CLOCK_MOCK not being enabled?  
>>
>> You have to add it to the relevant config.
>>
>> Please read: github.com/linux-netdev/nipa/wiki/Netdev-CI-system
> 
> Sorry, wrong link, this:
> 
> https://github.com/linux-netdev/nipa/wiki/How-to-run-netdev-selftests-CI-style
I did follow the guid, ran the test on the vng environment and it still
passed the test. Is there more debuggability on the CI system? Can you
share the .config file it generated while running the test? Or the
commands it tries to run so I can verify them locally?


The commands I ran were:

make mrproper
vng --build  --config tools/testing/selftests/drivers/net/netdevsim/config
vng -v --run . --user root --cpus 4 -- tools/testing/selftests/net/ptp.py

The tests were done on the ARM64 Fedora 44 with the default kernel
6.19.14-300.fc44.aarch64 running inside the Parallels Desktop VM.