From: Sven Eckelmann <sven@narfation.org>
To: Marek Lindner <mareklindner@neomailbox.ch>,
Simon Wunderlich <sw@simonwunderlich.de>,
Antonio Quartulli <a@unstable.cc>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] batman-adv: initialize "struct batadv_tvlv_tt_vlan_data"->reserved field
Date: Mon, 05 Apr 2021 12:06:40 +0200 [thread overview]
Message-ID: <8010915.lm9TqgPHxW@sven-l14> (raw)
In-Reply-To: <b98babbe-eb85-2b78-d7a4-d3ac6cda5e5b@i-love.sakura.ne.jp>
[-- Attachment #1: Type: text/plain, Size: 508 bytes --]
On Monday, 5 April 2021 12:02:02 CEST Tetsuo Handa wrote:
[...]
> > Thanks but this patch is incomplete. Please also fix
> > batadv_tt_prepare_tvlv_global_data (exactly the same way)
>
> Indeed. Hmm, batadv_send_tt_request() is already using kzalloc().
> Which approach ( "->reserved = 0" or "kzalloc()") do you prefer for
> batadv_tt_prepare_tvlv_global_data() and batadv_tt_prepare_tvlv_local_data() ?
Lets stick with the approach you've used in your v1 version - "->reserved = 0"
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-04-05 10:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-05 5:33 [PATCH] batman-adv: initialize "struct batadv_tvlv_tt_vlan_data"->reserved field Tetsuo Handa
2021-04-05 7:39 ` Sven Eckelmann
2021-04-05 10:02 ` Tetsuo Handa
2021-04-05 10:06 ` Sven Eckelmann [this message]
2021-04-05 10:16 ` [PATCH v2] " Tetsuo Handa
2021-04-05 11:09 ` Sven Eckelmann
2021-04-05 22:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8010915.lm9TqgPHxW@sven-l14 \
--to=sven@narfation.org \
--cc=a@unstable.cc \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=mareklindner@neomailbox.ch \
--cc=netdev@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox