* [PATCH] net: HNS: fix MDIO dependencies
@ 2015-10-09 12:53 Arnd Bergmann
2015-10-12 12:41 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2015-10-09 12:53 UTC (permalink / raw)
To: netdev
Cc: davem, Yisen Zhuang, Kenneth Lee, huangdaode, Zhangfei Gao,
linux-kernel, linux-arm-kernel
The newly introduced HNS_MDIO Kconfig symbol selects 'MDIO', but
that is the wrong symbol as the code used by this driver is
provided by PHYLIB rather than the MDIO driver. Also, there is
no need to make this driver user selectable, because it is already
selected by all drivers that need it.
This changes the Kconfig file to select the correct library, and
to make the option silent.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 5b904d39406 ("net: add Hisilicon Network Subsystem MDIO support")
diff --git a/drivers/net/ethernet/hisilicon/Kconfig b/drivers/net/ethernet/hisilicon/Kconfig
index 165b5a8aa2ea..8d12b587809e 100644
--- a/drivers/net/ethernet/hisilicon/Kconfig
+++ b/drivers/net/ethernet/hisilicon/Kconfig
@@ -24,7 +24,6 @@ config HIX5HD2_GMAC
config HIP04_ETH
tristate "HISILICON P04 Ethernet support"
- select PHYLIB
select MARVELL_PHY
select MFD_SYSCON
select HNS_MDIO
@@ -33,8 +32,8 @@ config HIP04_ETH
want to use the internal ethernet then you should answer Y to this.
config HNS_MDIO
- tristate "Hisilicon HNS MDIO device Support"
- select MDIO
+ tristate
+ select PHYLIB
---help---
This selects the HNS MDIO support. It is needed by HNS_DSAF to access
the PHY
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: HNS: fix MDIO dependencies
2015-10-09 12:53 [PATCH] net: HNS: fix MDIO dependencies Arnd Bergmann
@ 2015-10-12 12:41 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-10-12 12:41 UTC (permalink / raw)
To: arnd
Cc: netdev, Yisen.Zhuang, liguozhu, huangdaode, zhangfei.gao,
linux-kernel, linux-arm-kernel
From: Arnd Bergmann <arnd@arndb.de>
Date: Fri, 09 Oct 2015 14:53:54 +0200
> The newly introduced HNS_MDIO Kconfig symbol selects 'MDIO', but
> that is the wrong symbol as the code used by this driver is
> provided by PHYLIB rather than the MDIO driver. Also, there is
> no need to make this driver user selectable, because it is already
> selected by all drivers that need it.
>
> This changes the Kconfig file to select the correct library, and
> to make the option silent.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 5b904d39406 ("net: add Hisilicon Network Subsystem MDIO support")
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-12 12:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-09 12:53 [PATCH] net: HNS: fix MDIO dependencies Arnd Bergmann
2015-10-12 12:41 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox