Netdev List
 help / color / mirror / Atom feed
From: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
To: Paolo Abeni <pabeni@redhat.com>,
	Donald Hunter <donald.hunter@gmail.com>,
	Jakub Kicinski <kuba@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Simon Horman <horms@kernel.org>,
	Felix Maurer <fmaurer@redhat.com>,
	Danielle Ratson <danieller@nvidia.com>,
	Fernando Fernandez Mancera <fmancera@suse.de>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH net] netlink: specs: rt-link: fix ipv6 devconf doc
Date: Thu, 27 Aug 2026 11:39:30 +0000	[thread overview]
Message-ID: <83c08bb5-7977-405b-9a92-d846fec8e9ab@fiberby.net> (raw)
In-Reply-To: <08c53736-eaaa-47b9-a65c-b920d21b2993@redhat.com>

On 8/27/26 10:55 AM, Paolo Abeni wrote:
> On 8/24/26 12:38 PM, Asbjørn Sloth Tønnesen wrote:
>> devconf is even odder than described in the blamed commit, where bpth
>> IPv4 and IPv6 are described in an identical way:
>> "u32 indexed by ipv?-devconf - 1 on output, on input it's a nest".
>>
>> There are two issues with that line for IPv6:
>>
>> 1) The subtraction is an IPv4 specific quirk, to avoid having an unused
>>     u32 at index 0, thus saving 4 bytes per net device being dumped:
>>
>>     - In include/uapi/linux/ip.h the IPV4_DEVCONF_* enum begins with
>>       IPV4_DEVCONF_FORWARDING = 1, so the enum starts at 1, which is
>>       the reason for the subtraction in the IPv4 variant.
>>
>>     - In include/uapi/linux/ipv6.h the DEVCONF_* enum begins with
>>       DEVCONF_FORWARDING = 0, so subtraction would underflow.
>>
>>     - ipv6_store_devconf() in net/ipv6/addrconf.c also doesn't do the
>>       subtraction in the output path.
>>
>> 2) Setting IPv6 devconf through Netlink is not yet supported, as
>>     IFLA_INET6_CONF is not handled in inet6_set_link_af().
>>
>> Fixes: 720447bd0b24 ("netlink: specs: rt-link: remove implicit structs from devconf")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
> Nowadays net PRs are already too big due more-or-less security-relevant
> changes. I think this is better suited for net-next, with no 'fixes' tag
> nor stable cc, WDYT?

The unsupported input is the main doc correction, that I would like to go into
v7.3 and earlier, as Fernando is planning to add that support for v7.4.

I stumbled upon this, as I was trying to getting rid of some sysctl calls
in an internal provisioning tool.

If the PR size is already an issue for rc1, then I can resubmit when net-next opens.
(I assumed that you were trying to make the net PR sizes into an reversed xmas tree)

It's likely going to end up in stable regardless, it's just easier for Greg and
Sasha when it's tagged.

      reply	other threads:[~2026-08-27 11:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-24 10:38 [PATCH net] netlink: specs: rt-link: fix ipv6 devconf doc Asbjørn Sloth Tønnesen
2026-08-24 10:42 ` Fernando Fernandez Mancera
2026-08-27 10:55 ` Paolo Abeni
2026-08-27 11:39   ` Asbjørn Sloth Tønnesen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83c08bb5-7977-405b-9a92-d846fec8e9ab@fiberby.net \
    --to=ast@fiberby.net \
    --cc=danieller@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=edumazet@google.com \
    --cc=fmancera@suse.de \
    --cc=fmaurer@redhat.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox