public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* igb: XDP/ZC busy polling
@ 2025-02-07  8:38 Kurt Kanzenbach
  2025-02-07 13:26 ` Joe Damato
  0 siblings, 1 reply; 2+ messages in thread
From: Kurt Kanzenbach @ 2025-02-07  8:38 UTC (permalink / raw)
  To: Joe Damato
  Cc: Sebastian Andrzej Siewior, Stanislav Fomichev, netdev,
	intel-wired-lan

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

Hello Joe,

I noticed that XDP/ZC busy polling does not work anymore in combination
with igb driver. This seems to be related to commit 5ef44b3cb43b ("xsk:
Bring back busy polling support") which relies on
netif_queue_set_napi().

I see you implemented it for e1000, igc and so on. However, igb is
missing. Do you have any plans to add the missing registration to igb?
Just asking. Otherwise, I can send a patch for it.

Thanks,
Kurt

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: igb: XDP/ZC busy polling
  2025-02-07  8:38 igb: XDP/ZC busy polling Kurt Kanzenbach
@ 2025-02-07 13:26 ` Joe Damato
  0 siblings, 0 replies; 2+ messages in thread
From: Joe Damato @ 2025-02-07 13:26 UTC (permalink / raw)
  To: Kurt Kanzenbach
  Cc: Sebastian Andrzej Siewior, Stanislav Fomichev, netdev,
	intel-wired-lan

On Fri, Feb 07, 2025 at 09:38:41AM +0100, Kurt Kanzenbach wrote:
> Hello Joe,
> 
> I noticed that XDP/ZC busy polling does not work anymore in combination
> with igb driver. This seems to be related to commit 5ef44b3cb43b ("xsk:
> Bring back busy polling support") which relies on
> netif_queue_set_napi().
> 
> I see you implemented it for e1000, igc and so on. However, igb is
> missing. Do you have any plans to add the missing registration to igb?
> Just asking. Otherwise, I can send a patch for it.

Please feel free; I don't have an igb device so I wouldn't be able
to test it, but I'd happily review it so please CC me.

BTW, I wrote a small series that updates the documentation and adds
a test for AF_XDP [1] that you may want to consider applying/running
(if it is not merged by the time you add support to igb).

[1]: https://lore.kernel.org/lkml/20250207030916.32751-1-jdamato@fastly.com/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-02-07 13:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-07  8:38 igb: XDP/ZC busy polling Kurt Kanzenbach
2025-02-07 13:26 ` Joe Damato

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox