From: Tariq Toukan <tariqt@mellanox.com>
To: Cong Wang <xiyou.wangcong@gmail.com>, Tariq Toukan <tariqt@mellanox.com>
Cc: David Miller <davem@davemloft.net>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
eranbe@mellanox.com
Subject: Re: [PATCH net] net: rollback orig value on failure of dev_qdisc_change_tx_queue_len
Date: Sun, 22 Jul 2018 10:31:12 +0300 [thread overview]
Message-ID: <87a8fd21-aa7d-5dae-72ba-ef10dcba23f6@mellanox.com> (raw)
In-Reply-To: <CAM_iQpV-ks7A=PoiFqqf-iW4xXWcKeAaKnBGNP=dCP0DdZwgdQ@mail.gmail.com>
On 19/07/2018 8:25 PM, Cong Wang wrote:
> On Thu, Jul 19, 2018 at 7:34 AM Tariq Toukan <tariqt@mellanox.com> wrote:
>>
>> Fix dev_change_tx_queue_len so it rolls back original value
>> upon a failure in dev_qdisc_change_tx_queue_len.
>> This is already done for notifirers' failures, share the code.
>>
>> The revert of changes in dev_qdisc_change_tx_queue_len
>> in such case is needed but missing (marked as TODO), yet it is
>> still better to not apply the new requested value.
>
> You misunderstand the TODO, that is for reverting tx queue len
> change for previous queues in the loop. I still don't have any
> nice solution for this yet.
>
I understood this, but maybe didn't describe it clearly. I'll re-phrase.
> Yeah, your change itself looks good.
>
Thanks.
> Please update the changelog.
>
> Thanks.
>
prev parent reply other threads:[~2018-07-22 8:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 14:34 [PATCH net] net: rollback orig value on failure of dev_qdisc_change_tx_queue_len Tariq Toukan
2018-07-19 17:25 ` Cong Wang
2018-07-22 7:31 ` Tariq Toukan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8fd21-aa7d-5dae-72ba-ef10dcba23f6@mellanox.com \
--to=tariqt@mellanox.com \
--cc=davem@davemloft.net \
--cc=eranbe@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox