From: Atzm Watanabe <atzm@stratosphere.co.jp>
To: Daniel Borkmann <dborkman@redhat.com>
Cc: netdev@vger.kernel.org,
Stephen Hemminger <stephen@networkplumber.org>,
Ben Hutchings <bhutchings@solarflare.com>,
David Miller <davem@davemloft.net>,
David Laight <David.Laight@ACULAB.COM>
Subject: Re: [PATCH v4 3/3] packet: deliver VLAN TPID to userspace
Date: Tue, 17 Dec 2013 23:28:24 +0900 [thread overview]
Message-ID: <87bo0f7drr.wl%atzm@stratosphere.co.jp> (raw)
In-Reply-To: <52B05B61.9020200@redhat.com>
At Tue, 17 Dec 2013 15:10:41 +0100,
Daniel Borkmann wrote:
>
> On 12/17/2013 02:53 PM, Atzm Watanabe wrote:
> > This enables userspace to get VLAN TPID as well as the VLAN TCI.
> >
> > Signed-off-by: Atzm Watanabe <atzm@stratosphere.co.jp>
>
> Acked-by: Daniel Borkmann <dborkman@redhat.com>
>
> Looks good, imho.
>
> Maybe, later on in a follow-up you could also update
> Documentation/networking/packet_mmap.txt in places
> related to vlan bits, so that people are aware of this.
Thank you for the quick reviewing and pointing.
Yes, I'll send a patch that updates documentation later.
prev parent reply other threads:[~2013-12-17 14:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 13:53 [PATCH v4 3/3] packet: deliver VLAN TPID to userspace Atzm Watanabe
2013-12-17 14:10 ` Daniel Borkmann
2013-12-17 14:28 ` Atzm Watanabe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bo0f7drr.wl%atzm@stratosphere.co.jp \
--to=atzm@stratosphere.co.jp \
--cc=David.Laight@ACULAB.COM \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox