From: Eric Dumazet <eric.dumazet@gmail.com>
To: Sheng Lan <lansheng@huawei.com>,
stephen@networkplumber.org, davem@davemloft.net
Cc: netdev@vger.kernel.org, netem@lists.linux-foundation.org,
xuhanbing@huawei.com, zhengshaoyu@huawei.com,
jiqin.ji@huawei.com, liuzhiqiang26@huawei.com,
yuehaibing@huawei.com
Subject: Re: [PATCH v2] net: netem: fix skb length BUG_ON in __skb_to_sgvec
Date: Thu, 28 Feb 2019 09:03:47 -0800 [thread overview]
Message-ID: <87c52b93-ef66-68f3-678b-2a29f678dbbf@gmail.com> (raw)
In-Reply-To: <febde466-cd87-9a63-7904-9447b23104c3@huawei.com>
On 02/28/2019 02:47 AM, Sheng Lan wrote:
> From: Sheng Lan <lansheng@huawei.com>
>
> It can be reproduced by following steps:
> 1. virtio_net NIC is configured with gso/tso on
> 2. configure nginx as http server with an index file bigger than 1M bytes
> 3. use tc netem to produce duplicate packets and delay:
> tc qdisc add dev eth0 root netem delay 100ms 10ms 30% duplicate 90%
> 4. continually curl the nginx http server to get index file on client
> 5. BUG_ON is seen quickly
>
...
> To fix it, netem returns NET_XMIT_SUCCESS to upper stack
> when it clones a duplicate packet.
>
> Fixes: 35d889d1 ("sch_netem: fix skb leak in netem_enqueue()")
> Signed-off-by: Sheng Lan <lansheng@huawei.com>
> Reported-by: Qin Ji <jiqin.ji@huawei.com>
> Suggested-by: Eric Dumazet <eric.dumazet@gmail.com>
>
> ---
Signed-off-by: Eric Dumazet <edumazet@google.com>
Thanks.
next prev parent reply other threads:[~2019-02-28 17:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 10:47 [PATCH v2] net: netem: fix skb length BUG_ON in __skb_to_sgvec Sheng Lan
2019-02-28 17:03 ` Eric Dumazet [this message]
2019-02-28 18:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87c52b93-ef66-68f3-678b-2a29f678dbbf@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=jiqin.ji@huawei.com \
--cc=lansheng@huawei.com \
--cc=liuzhiqiang26@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=netem@lists.linux-foundation.org \
--cc=stephen@networkplumber.org \
--cc=xuhanbing@huawei.com \
--cc=yuehaibing@huawei.com \
--cc=zhengshaoyu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox