From: Petr Machata <petrm@nvidia.com>
To: Alok Tiwari <alok.a.tiwari@oracle.com>
Cc: <idosch@nvidia.com>, <petrm@nvidia.com>, <andrew+netdev@lunn.ch>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <netdev@vger.kernel.org>,
<alok.a.tiwarilinux@gmail.com>
Subject: Re: [PATCH net-next] mlxsw: spectrum: Remove redundant return in KVDL free function
Date: Mon, 12 Oct 2026 10:44:28 +0200 [thread overview]
Message-ID: <87h5ir8g0j.fsf@pmachata.org> (raw)
In-Reply-To: <20261011115227.21760-1-alok.a.tiwari@oracle.com> (Alok Tiwari's message of "Sun, 11 Oct 2026 04:52:22 -0700")
Alok Tiwari <alok.a.tiwari@oracle.com> writes:
> Call mlxsw_sp2_kvdl_part_free() directly instead of returning its void
> expression from mlxsw_sp2_kvdl_free().
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Thanks for the patch, however:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches
This is pure coding style patch. The original code is not canonical, but
is correct and understandable to anyone who understands C. Sorry, but
let's not have this.
pw-bot: rejected
prev parent reply other threads:[~2026-10-12 8:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-11 11:52 [PATCH net-next] mlxsw: spectrum: Remove redundant return in KVDL free function Alok Tiwari
2026-10-12 8:44 ` Petr Machata [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h5ir8g0j.fsf@pmachata.org \
--to=petrm@nvidia.com \
--cc=alok.a.tiwari@oracle.com \
--cc=alok.a.tiwarilinux@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox