* [PATCH net-next] mlxsw: spectrum: Remove redundant return in KVDL free function
@ 2026-10-11 11:52 Alok Tiwari
2026-10-12 8:44 ` Petr Machata
0 siblings, 1 reply; 2+ messages in thread
From: Alok Tiwari @ 2026-10-11 11:52 UTC (permalink / raw)
To: idosch, petrm, andrew+netdev, davem, edumazet, kuba, pabeni,
netdev
Cc: alok.a.tiwarilinux, alok.a.tiwari
Call mlxsw_sp2_kvdl_part_free() directly instead of returning its void
expression from mlxsw_sp2_kvdl_free().
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
---
drivers/net/ethernet/mellanox/mlxsw/spectrum2_kvdl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum2_kvdl.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum2_kvdl.c
index 24ff305a2995..6a23d1626519 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum2_kvdl.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum2_kvdl.c
@@ -163,7 +163,7 @@ static void mlxsw_sp2_kvdl_free(struct mlxsw_sp *mlxsw_sp, void *priv,
struct mlxsw_sp2_kvdl *kvdl = priv;
struct mlxsw_sp2_kvdl_part *part = kvdl->parts[type];
- return mlxsw_sp2_kvdl_part_free(mlxsw_sp, part, size, entry_index);
+ mlxsw_sp2_kvdl_part_free(mlxsw_sp, part, size, entry_index);
}
static int mlxsw_sp2_kvdl_alloc_size_query(struct mlxsw_sp *mlxsw_sp,
--
2.52.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] mlxsw: spectrum: Remove redundant return in KVDL free function
2026-10-11 11:52 [PATCH net-next] mlxsw: spectrum: Remove redundant return in KVDL free function Alok Tiwari
@ 2026-10-12 8:44 ` Petr Machata
0 siblings, 0 replies; 2+ messages in thread
From: Petr Machata @ 2026-10-12 8:44 UTC (permalink / raw)
To: Alok Tiwari
Cc: idosch, petrm, andrew+netdev, davem, edumazet, kuba, pabeni,
netdev, alok.a.tiwarilinux
Alok Tiwari <alok.a.tiwari@oracle.com> writes:
> Call mlxsw_sp2_kvdl_part_free() directly instead of returning its void
> expression from mlxsw_sp2_kvdl_free().
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Thanks for the patch, however:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches
This is pure coding style patch. The original code is not canonical, but
is correct and understandable to anyone who understands C. Sorry, but
let's not have this.
pw-bot: rejected
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-12 8:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-11 11:52 [PATCH net-next] mlxsw: spectrum: Remove redundant return in KVDL free function Alok Tiwari
2026-10-12 8:44 ` Petr Machata
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox