* [PATCH net] ieee802154: hwsim: free PIB after hardware unregister
@ 2026-11-13 13:41 Yichong Chen
2026-11-17 10:17 ` Miquel Raynal
0 siblings, 1 reply; 2+ messages in thread
From: Yichong Chen @ 2026-11-13 13:41 UTC (permalink / raw)
To: Alexander Aring, Stefan Schmidt, Miquel Raynal, linux-wpan
Cc: netdev, linux-kernel, Zhan Jun, syzbot+8a8482d4c33cc58babb4,
stable, Yichong Chen
From: Zhan Jun <zhanjun@uniontech.com>
hwsim_del() queued the current PIB for RCU freeing before calling
ieee802154_unregister_hw(). Unregistering the hardware closes its
interfaces and aborts an in-progress scan; scan cleanup calls
set_channel(), which replaces the same phy->pib and queues the old object
for RCU freeing again. KASAN then reports an invalid free in
hwsim_update_pib().
Unregister the hardware first, then atomically detach the final PIB under
pib_lock and queue only that current object for RCU freeing. This lets all
driver callbacks finish before the PIB is reclaimed and avoids freeing a
PIB that was already replaced during teardown.
Reported-by: syzbot+8a8482d4c33cc58babb4@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/all/6af5f575.b350cda4.2b6a63.0000.GAE@google.com/T/
Fixes: f25da51fdc38 ("ieee802154: hwsim: add replacement for fakelb")
Cc: stable@vger.kernel.org
Signed-off-by: Zhan Jun <zhanjun@uniontech.com>
Signed-off-by: Yichong Chen <chenyichong@uniontech.com>
---
drivers/net/ieee802154/mac802154_hwsim.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ieee802154/mac802154_hwsim.c b/drivers/net/ieee802154/mac802154_hwsim.c
index a9bd1555d2dc..a65ae2afb789 100644
--- a/drivers/net/ieee802154/mac802154_hwsim.c
+++ b/drivers/net/ieee802154/mac802154_hwsim.c
@@ -1008,12 +1008,16 @@ static void hwsim_del(struct hwsim_phy *phy)
list_del_rcu(&e->list);
hwsim_free_edge(e);
}
- pib = rcu_dereference(phy->pib);
rcu_read_unlock();
+ ieee802154_unregister_hw(phy->hw);
+
+ spin_lock_bh(&phy->pib_lock);
+ pib = rcu_replace_pointer(phy->pib, NULL,
+ lockdep_is_held(&phy->pib_lock));
+ spin_unlock_bh(&phy->pib_lock);
kfree_rcu(pib, rcu);
- ieee802154_unregister_hw(phy->hw);
ieee802154_free_hw(phy->hw);
}
--
2.51.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net] ieee802154: hwsim: free PIB after hardware unregister
2026-11-13 13:41 [PATCH net] ieee802154: hwsim: free PIB after hardware unregister Yichong Chen
@ 2026-11-17 10:17 ` Miquel Raynal
0 siblings, 0 replies; 2+ messages in thread
From: Miquel Raynal @ 2026-11-17 10:17 UTC (permalink / raw)
To: Yichong Chen
Cc: Alexander Aring, Stefan Schmidt, linux-wpan, netdev, linux-kernel,
Zhan Jun, syzbot+8a8482d4c33cc58babb4, stable
On 13/11/2026 at 21:41:41 +08, Yichong Chen <chenyichong@uniontech.com> wrote:
> From: Zhan Jun <zhanjun@uniontech.com>
>
> hwsim_del() queued the current PIB for RCU freeing before calling
> ieee802154_unregister_hw(). Unregistering the hardware closes its
> interfaces and aborts an in-progress scan; scan cleanup calls
> set_channel(), which replaces the same phy->pib and queues the old object
> for RCU freeing again. KASAN then reports an invalid free in
> hwsim_update_pib().
>
> Unregister the hardware first, then atomically detach the final PIB under
> pib_lock and queue only that current object for RCU freeing. This lets all
> driver callbacks finish before the PIB is reclaimed and avoids freeing a
> PIB that was already replaced during teardown.
>
> Reported-by: syzbot+8a8482d4c33cc58babb4@syzkaller.appspotmail.com
> Closes: https://lore.kernel.org/all/6af5f575.b350cda4.2b6a63.0000.GAE@google.com/T/
> Fixes: f25da51fdc38 ("ieee802154: hwsim: add replacement for fakelb")
> Cc: stable@vger.kernel.org
> Signed-off-by: Zhan Jun <zhanjun@uniontech.com>
> Signed-off-by: Yichong Chen <chenyichong@uniontech.com>
This is a duplicate of:
https://lore.kernel.org/all/20260627235805.17310-1-alhouseenyousef@gmail.com/
https://lore.kernel.org/all/20260709221858.158063-1-devnexen@gmail.com/
https://lore.kernel.org/all/20260919223434.3882824-1-benquike@gmail.com/
Miquèl
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-17 10:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-13 13:41 [PATCH net] ieee802154: hwsim: free PIB after hardware unregister Yichong Chen
2026-11-17 10:17 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox