From: Kalle Valo <kvalo@qca.qualcomm.com>
To: nick <xerofoify@gmail.com>
Cc: <linville@tuxdriver.com>, <linux-wireless@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: FIX ME locking is implemented?
Date: Sat, 22 Nov 2014 16:41:07 +0200 [thread overview]
Message-ID: <87lhn38fi4.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <54709610.6020502@gmail.com> (nick's message of "Sat, 22 Nov 2014 08:56:32 -0500")
nick <xerofoify@gmail.com> writes:
> I am wondering why the fix me in the code below still exists as this
> code is clearly being locked properly with a spin lock on the lock
> related to the created linked list in this code.
It would be nice to mention what driver and file you are referring to.
So this is from ath6kl_tx_queue_full() in
drivers/net/wireless/ath/ath6kl/txrx.c.
> /* FIXME: Locking */
> spin_lock_bh(&ar->list_lock);
> list_for_each_entry(vif, &ar->vif_list, list) {
> if (vif->nw_type == ADHOC_NETWORK ||
> action != HTC_SEND_FULL_DROP) {
> spin_unlock_bh(&ar->list_lock);
>
> set_bit(NETQ_STOPPED, &vif->flags);
> netif_stop_queue(vif->ndev);
>
> return action;
> }
> }
> spin_unlock_bh(&ar->list_lock);
Most probably someone just forgot to update the comment, patches welcome :)
--
Kalle Valo
parent reply other threads:[~2014-11-22 14:41 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <54709610.6020502@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lhn38fi4.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox