From: "Bjørn Mork" <bjorn@mork.no>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] net: qmi_wwan: add ZTE MF60
Date: Thu, 05 Jul 2012 13:09:31 +0200 [thread overview]
Message-ID: <87obnujwgk.fsf@nemi.mork.no> (raw)
In-Reply-To: <20120705.031648.85978116859244029.davem@davemloft.net> (David Miller's message of "Thu, 05 Jul 2012 03:16:48 -0700 (PDT)")
David Miller <davem@davemloft.net> writes:
> From: Bjørn Mork <bjorn@mork.no>
> Date: Mon, 2 Jul 2012 19:53:17 +0200
>
>> +static const struct driver_info qmi_wwan_force_int2 = {
>
> Please get rid of that strange tab character and resubmit.
Sure. Will do.
Looks like a thoughtless copy-paste thing originally coming from
cdc_ether. Funny thing is that it has survived several incarnations
already, as this specific instance came from a copy-paste within the
same driver.
It's all checkpatch'es fault for not warning me :-)
Luckily all of these will go away when the whitelisting is removed
(i.e. when the USB interface number matching in 3.6 is available).
Bjørn
prev parent reply other threads:[~2012-07-05 11:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 17:53 [PATCH net] net: qmi_wwan: add ZTE MF60 Bjørn Mork
2012-07-05 10:16 ` David Miller
2012-07-05 11:09 ` Bjørn Mork [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87obnujwgk.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox