[PATCH net] net: qmi_wwan: add ZTE MF60

[PATCH net] net: qmi_wwan: add ZTE MF60

[Bjørn Mork]

Adding a device with limited QMI support. It does not support
normal QMI_WDS commands for connection management. Instead,
sending a QMI_CTL SET_INSTANCE_ID command is required to
enable the network interface:

  01 0f 00 00 00 00 00 00  20 00 04 00 01 01 00 00

A number of QMI_DMS and QMI_NAS commands are also supported
for optional device management.

Signed-off-by: Bjørn Mork <bjorn@mork.no>
---
 drivers/net/usb/qmi_wwan.c |   18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index b01960f..5badafd 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -346,6 +346,15 @@ static const struct driver_info	qmi_wwan_force_int1 = {
 	.data		= BIT(1), /* interface whitelist bitmap */
 };
 
+static const struct driver_info	qmi_wwan_force_int2 = {
+	.description	= "Qualcomm WWAN/QMI device",
+	.flags		= FLAG_WWAN,
+	.bind		= qmi_wwan_bind_shared,
+	.unbind		= qmi_wwan_unbind_shared,
+	.manage_power	= qmi_wwan_manage_power,
+	.data		= BIT(2), /* interface whitelist bitmap */
+};
+
 static const struct driver_info	qmi_wwan_force_int3 = {
 	.description	= "Qualcomm WWAN/QMI device",
 	.flags		= FLAG_WWAN,
@@ -498,6 +507,15 @@ static const struct usb_device_id products[] = {
 		.bInterfaceProtocol = 0xff,
 		.driver_info        = (unsigned long)&qmi_wwan_force_int4,
 	},
+	{	/* ZTE MF60 */
+		.match_flags	    = USB_DEVICE_ID_MATCH_DEVICE | USB_DEVICE_ID_MATCH_INT_INFO,
+		.idVendor           = 0x19d2,
+		.idProduct          = 0x1402,
+		.bInterfaceClass    = 0xff,
+		.bInterfaceSubClass = 0xff,
+		.bInterfaceProtocol = 0xff,
+		.driver_info        = (unsigned long)&qmi_wwan_force_int2,
+	},
 	{	/* Sierra Wireless MC77xx in QMI mode */
 		.match_flags	    = USB_DEVICE_ID_MATCH_DEVICE | USB_DEVICE_ID_MATCH_INT_INFO,
 		.idVendor           = 0x1199,
-- 
1.7.10

Re: [PATCH net] net: qmi_wwan: add ZTE MF60

[David Miller]

From: Bjørn Mork <bjorn@mork.no>
Date: Mon,  2 Jul 2012 19:53:17 +0200

> +static const struct driver_info	qmi_wwan_force_int2 = {

Please get rid of that strange tab character and resubmit.

Re: [PATCH net] net: qmi_wwan: add ZTE MF60

[Bjørn Mork]

David Miller <davem@davemloft.net> writes:

> From: Bjørn Mork <bjorn@mork.no>
> Date: Mon,  2 Jul 2012 19:53:17 +0200
>
>> +static const struct driver_info	qmi_wwan_force_int2 = {
>
> Please get rid of that strange tab character and resubmit.

Sure. Will do.

Looks like a thoughtless copy-paste thing originally coming from
cdc_ether.  Funny thing is that it has survived several incarnations
already, as this specific instance came from a copy-paste within the
same driver.

It's all checkpatch'es fault for not warning me :-)

Luckily all of these will go away when the whitelisting is removed
(i.e. when the USB interface number matching in 3.6 is available).


Bjørn