From: Roman Gushchin <roman@kernel.org>
To: Linus Walleij <linusw@kernel.org>
Cc: "Jakub Kicinski" <kuba@kernel.org>,
"Roman Gushchin" <roman.gushchin@linux.dev>,
"Hans Ulli Kroll" <ulli.kroll@googlemail.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Paolo Abeni" <pabeni@redhat.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"Myeonghun Pak" <mhun512@gmail.com>,
"Eric Dumazet" <edumazet@kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v8 00/19] net: ethernet: cortina: Fix Gemini RX/TX buffer management
Date: Fri, 20 Nov 2026 10:39:00 -0800 [thread overview]
Message-ID: <87pkvzfiuz.fsf@kernel.org> (raw)
In-Reply-To: <CAD++jLnP2EfgM_isbdmidLOc0ZUaoq+bgD+cvw9sKLJCynniWw@mail.gmail.com>
Linus Walleij <linusw@kernel.org> writes:
> On Fri, Nov 20, 2026 at 1:52 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
>> > I think it could be applied and then maybe I can follow up some
>> > of the comments later once this is landed and the ethernet is
>> > working properly.
>>
>> Ugh, not only is this pile over 15 patches
>
> I blame that on Sashiko's constant "oh by the way fix this too"
> and ability to find otherworldly error paths...
>
>> it also fell victim to the
>> mass rename of kmalloc to kmalloc_obj that landed in Linus's tree :/
>
> Oh Christ :D
>
>> Please:
>> - rebase
>> - drop all the Fixes tags here, net-next == no Fixes tags
>
> NB: the Sashiko used by netdev insists on us adding these so we
> are giving incoherent messages here. Clearly Sashiko can see
> the prefix on each series and know whether Fixes: are applicable
> or not. We need to fix the Sashiko
> prompts. (I can perhaps do it if I know how, Roman?)
>
> Sometimes Fixes: are used for "nonurgent fixes" in other kernel
> trees but maybe it just doesn't work with netdev.
A clearly written text with rules in English would work, I can do the
rest. But it's for "upstream" Sashiko, netdev-specific Sashiko is
supported by Jakub and has quite significantly diverged.
prev parent reply other threads:[~2026-11-20 18:39 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 13:30 [PATCH net-next v8 00/19] net: ethernet: cortina: Fix Gemini RX/TX buffer management Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 01/19] net: ethernet: cortina: Keep shared free queue parent-owned Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 02/19] net: ethernet: cortina: Keep ports bound for shared IRQ Linus Walleij
2026-11-16 14:45 ` netdev-bot+sashiko
2026-11-17 7:53 ` Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 03/19] net: ethernet: cortina: Drain free queue IRQ before resize Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 04/19] net: ethernet: cortina: Normalize free queue pointers on rebuild Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 05/19] net: ethernet: cortina: Correct free queue DMA mappings Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 06/19] net: ethernet: cortina: Index free queue fragments with XArray Linus Walleij
2026-11-16 14:45 ` netdev-bot+sashiko
2026-11-17 7:57 ` Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 07/19] net: ethernet: cortina: Preserve in-flight free queue pages Linus Walleij
2026-11-16 14:45 ` netdev-bot+sashiko
2026-11-17 7:59 ` Linus Walleij
2026-11-17 8:01 ` Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 08/19] net: ethernet: cortina: Rotate free queue page allocation Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 09/19] net: ethernet: cortina: Recycle claimed free queue pages Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 10/19] net: ethernet: cortina: Separate RX buffer capacity from free queue size Linus Walleij
2026-11-16 14:45 ` netdev-bot+sashiko
2026-11-17 8:04 ` Linus Walleij
2026-11-18 20:49 ` Simon Horman
2026-11-18 21:01 ` Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 11/19] net: ethernet: cortina: Validate RX fragment lengths Linus Walleij
2026-11-16 14:45 ` netdev-bot+sashiko
2026-11-17 8:07 ` Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 12/19] net: ethernet: cortina: Account RX buffer size in truesize Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 13/19] net: ethernet: cortina: Release partial RX frames on stop Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 14/19] net: ethernet: cortina: Scale Gemini RX queues to system memory Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 15/19] net: ethernet: cortina: Serialize TX completion statistics Linus Walleij
2026-11-16 14:45 ` netdev-bot+sashiko
2026-11-17 8:08 ` Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 16/19] net: ethernet: cortina: Scope RX statistics updates Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 17/19] net: ethernet: cortina: Drain RX coalescing timer on stop Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 18/19] net: ethernet: cortina: Reject TX rings smaller than retained pointers Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 19/19] net: ethernet: cortina: Fix ethtool statistics reads Linus Walleij
2026-11-16 14:45 ` netdev-bot+sashiko
2026-11-17 8:09 ` Linus Walleij
2026-11-17 8:12 ` [PATCH net-next v8 00/19] net: ethernet: cortina: Fix Gemini RX/TX buffer management Linus Walleij
2026-11-20 0:52 ` Jakub Kicinski
2026-11-20 10:26 ` Linus Walleij
2026-11-20 18:21 ` Jakub Kicinski
2026-11-20 18:39 ` Roman Gushchin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pkvzfiuz.fsf@kernel.org \
--to=roman@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=linusw@kernel.org \
--cc=mhun512@gmail.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=roman.gushchin@linux.dev \
--cc=ulli.kroll@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox