From: Andrew Lunn <andrew@lunn.ch>
To: Daniel Pawlik <pawlik.dan@gmail.com>
Cc: hkallweit1@gmail.com, linux@armlinux.org.uk,
netdev@vger.kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, kabel@kernel.org,
petr.wozniak@gmail.com, maxime.chevallier@bootlin.com,
olek2@wp.pl
Subject: Re: [PATCH net-next v3 2/2] net: sfp: skip PHY probe on bridge-less OEM SFP-10G-T revisions A and B
Date: Fri, 20 Nov 2026 13:56:29 +0100 [thread overview]
Message-ID: <8955d9e9-d7fd-4bd1-86d3-d128fbfcbf30@lunn.ch> (raw)
In-Reply-To: <20261120063756.3677554-3-pawlik.dan@gmail.com>
> +static void sfp_fixup_oem_10gt(struct sfp *sfp)
> +{
> + char rev = sfp->id.base.vendor_rev[0];
> +
> + /* Revisions A and B of this module have no RollBall I2C-to-MDIO
> + * bridge (on rev A, page 3 of the 0x51 EEPROM just echoes written
> + * bytes), so every RollBall command times out and the PHY probe
> + * keeps retrying for over nine minutes, holding rtnl_lock for ~20
> + * seconds per attempt. The PHY is not accessible at all, so use the
> + * module without one.
> + */
> + if (sfp_strlen(sfp->id.base.vendor_rev, 4) == 1 &&
> + (rev == 'A' || rev == 'B')) {
> + dev_info(sfp->dev,
> + "rev %c has no RollBall MDIO bridge, not probing for a PHY\n",
> + rev);
Quirks don't print anything. Please change this to dev_debug(), or
remove it.
Otherwise this looks good.
Andrew
prev parent reply other threads:[~2026-11-20 12:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 6:37 [PATCH net-next v3 0/2] net: sfp: skip PHY probe on bridge-less OEM SFP-10G-T Daniel Pawlik
2026-11-20 6:37 ` [PATCH net-next v3 1/2] net: sfp: move sfp_strlen() above the quirk fixups Daniel Pawlik
2026-11-20 12:52 ` Andrew Lunn
2026-11-20 6:37 ` [PATCH net-next v3 2/2] net: sfp: skip PHY probe on bridge-less OEM SFP-10G-T revisions A and B Daniel Pawlik
2026-11-20 12:56 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8955d9e9-d7fd-4bd1-86d3-d128fbfcbf30@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kabel@kernel.org \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=olek2@wp.pl \
--cc=pabeni@redhat.com \
--cc=pawlik.dan@gmail.com \
--cc=petr.wozniak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox