From: David Ahern <dsa@cumulusnetworks.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
"David S. Miller" <davem@davemloft.net>,
Pan Bian <bianpan2016@163.com>
Cc: Roopa Prabhu <roopa@cumulusnetworks.com>,
Robert Shearman <rshearma@brocade.com>,
Tom Herbert <tom@herbertland.com>,
David Lebrun <david.lebrun@uclouvain.be>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] lwtunnel: fix error path in lwtunnel_fill_encap()
Date: Sat, 29 Apr 2017 07:03:07 -0600 [thread overview]
Message-ID: <8e97609b-732b-9a84-b088-ba7f4384a1eb@cumulusnetworks.com> (raw)
In-Reply-To: <20170428130347.53hagk77wh6scmcs@mwanda>
On 4/28/17 7:03 AM, Dan Carpenter wrote:
> We recently added a check to see if nla_nest_start() fails. There are
> two issues with that. First, if it fails then I don't think we should
> call nla_nest_cancel(). Second, it's slightly convoluted but the
> current code returns success but we should return -EMSGSIZE instead.
>
> Fixes: a50fe0ffd76f ("lwtunnel: check return value of nla_nest_start")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Acked-by: David Ahern <dsa@cumulusnetworks.com>
next prev parent reply other threads:[~2017-04-29 13:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 13:03 [PATCH net-next] lwtunnel: fix error path in lwtunnel_fill_encap() Dan Carpenter
2017-04-29 13:03 ` David Ahern [this message]
2017-05-01 2:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e97609b-732b-9a84-b088-ba7f4384a1eb@cumulusnetworks.com \
--to=dsa@cumulusnetworks.com \
--cc=bianpan2016@163.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=david.lebrun@uclouvain.be \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=rshearma@brocade.com \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox