From: Song Liu <songliubraving@fb.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"ast@kernel.org" <ast@kernel.org>,
"peterz@infradead.org" <peterz@infradead.org>,
Kernel Team <Kernel-team@fb.com>,
"hannes@cmpxchg.org" <hannes@cmpxchg.org>,
Teng Qin <qinteng@fb.com>
Subject: Re: [PATCH bpf-next v6 0/2] bpf stackmap with build_id+offset
Date: Thu, 15 Mar 2018 00:34:20 +0000 [thread overview]
Message-ID: <90BD628F-C268-42C3-B3B4-A7548CEADDBA@fb.com> (raw)
In-Reply-To: <46bec038-f793-7ce6-686f-adee7f462dec@iogearbox.net>
> On Mar 14, 2018, at 5:29 PM, Daniel Borkmann <daniel@iogearbox.net> wrote:
>
> On 03/14/2018 06:23 PM, Song Liu wrote:
>> Changes v4 -> v6:
>>
>> 1. When kernel stack is added to stackmap with build_id, use fallback
>> mechanism to store ip (status == BPF_STACK_BUILD_ID_IP).
>>
>> Changes v4 -> v5:
>>
>> 1. Only allow build_id lookup in non-nmi context. Added comment and
>> commit message to highlight this limitation.
>> 2. Minor fix reported by kbuild test robot.
>>
>> Changes v3 -> v4:
>>
>> 1. Add fallback when build_id lookup failed. In this case, status is set
>> to BPF_STACK_BUILD_ID_IP, and ip of this entry is saved.
>> 2. Handle cases where vma is only part of the file (vma->vm_pgoff != 0).
>> Thanks to Teng for helping me identify this issue!
>> 3. Address feedbacks for previous versions.
>
> Applied to bpf-next, thanks Song!
>
> P.s.: In the merge commit I included your description from the original
> v1 cover letter to provide readers with some more context. Please don't
> remove such things in future from cover letter. Only the above doesn't
> really say much about the series overall.
Get it! Thanks Daniel!
Best,
Song
prev parent reply other threads:[~2018-03-15 0:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 17:23 [PATCH bpf-next v6 0/2] bpf stackmap with build_id+offset Song Liu
2018-03-14 17:23 ` [PATCH bpf-next v6 1/2] bpf: extend stackmap to save binary_build_id+offset instead of address Song Liu
2018-03-14 17:36 ` Song Liu
2018-03-14 17:39 ` Daniel Borkmann
2018-03-14 17:23 ` [PATCH bpf-next v6 2/2] bpf: add selftest for stackmap with BPF_F_STACK_BUILD_ID Song Liu
2018-03-15 0:29 ` [PATCH bpf-next v6 0/2] bpf stackmap with build_id+offset Daniel Borkmann
2018-03-15 0:34 ` Song Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90BD628F-C268-42C3-B3B4-A7548CEADDBA@fb.com \
--to=songliubraving@fb.com \
--cc=Kernel-team@fb.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=hannes@cmpxchg.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=qinteng@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox