Netdev List
 help / color / mirror / Atom feed
From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <netdev@vger.kernel.org>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	Aleksandr Loktionov <aleksandr.loktionov@intel.com>,
	Michal Schmidt <mschmidt@redhat.com>, <edumazet@kernel.org>,
	<horms@kernel.org>, <pabeni@redhat.com>, <davem@davemloft.net>,
	Jiri Pirko <jiri@resnulli.us>, Jonathan Corbet <corbet@lwn.net>,
	<skhan@linuxfoundation.org>, <rdunlap@infradead.org>,
	<andrew+netdev@lunn.ch>, <saeedm@nvidia.com>, <tariqt@nvidia.com>,
	<leon@kernel.org>, <mbloch@nvidia.com>,
	<jacob.e.keller@intel.com>, <jedrzej.jagielski@intel.com>,
	<anzaki@gmail.com>, <brett.creeley@amd.com>,
	<ohartoov@nvidia.com>, Petr Oros <poros@redhat.com>
Subject: Re: [PATCH net-next v5 12/15] devlink: give user option to allocate resources
Date: Thu, 19 Nov 2026 15:02:13 +0100	[thread overview]
Message-ID: <947c9fee-8d85-4b90-9018-7c021da9823e@intel.com> (raw)
In-Reply-To: <20261118170003.2f6501e3@kernel.org>

On 11/19/26 2:00 AM, Jakub Kicinski wrote:
> On Tue, 10 Nov 2026 15:07:21 +0100 Przemek Kitszel wrote:
>> Current devlink resources are designed as a thing that user could limit,
>> but there is not much otherwise that could be done with them.
>> Perhaps that's the reason there is not much adoption despite API being
>> there for multiple years.
>>
>> Add new mode of operation, where user could allocate/assign resources
>> (from a common pool) to specific devices.
>>
>> That requires a new .occ_set() driver callback, called on
>> DEVLINK_CMD_RESOURCE_SET with the requested DEVLINK_ATTR_RESOURCE_SIZE,
>> instead of staging the size until the next reload. Driver registers it
>> together with .occ_get() by devl_resource_occ_set_get_register(). For
>> such resources the getter value is reported as DEVLINK_ATTR_RESOURCE_SIZE,
>> as opposed to DEVLINK_ATTR_RESOURCE_OCC (current occupation) in the
>> "legacy" mode, and there is no DEVLINK_ATTR_RESOURCE_SIZE_NEW.
> 
> I haven't read the driver code but I wonder why you're making such
> changes. It seems like you want something like param cmode - your
> size change is applied at runtime which existing size_new stuff
> is built to require driver_init. Why not add cmode to the resource
> to express when change will be applied?
> 
> Why you're messing with "occ" I don't get at all. occ(upancy) is
> current use. See comments on the driver patch as well..


Good idea, resource with cmode=runtime matches what I need. As far as I
can tell now, swapping my occ_set for it does not turn the series upside
down: the driver still applies the change synchronously and can fail it,
size becomes the value set by the user, and occ goes back to the current
use.

  reply	other threads:[~2026-11-19 14:03 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 14:07 [PATCH net-next v5 00/15] devlink, mlx5, iavf, ice: XLVF for iavf Przemek Kitszel
2026-11-10 14:07 ` [PATCH net-next v5 01/15] devlink, mlx5: add init/fini ops for shared devlink Przemek Kitszel
2026-11-10 14:47   ` Jiri Pirko
2026-11-10 14:07 ` [PATCH net-next v5 02/15] ice: use shared devlink to store ice_adapters instead of custom xarray Przemek Kitszel
2026-11-10 14:07 ` [PATCH net-next v5 03/15] ice: add VF queue ena/dis helper functions Przemek Kitszel
2026-11-10 14:07 ` [PATCH net-next v5 04/15] ice: add helpers for Global RSS LUT alloc, free, vsi_update Przemek Kitszel
2026-11-12 23:07   ` netdev-bot+sashiko
2026-11-10 14:07 ` [PATCH net-next v5 05/15] ice: rename ICE_MAX_RSS_QS_PER_VF to ICE_MAX_QS_PER_VF_VCV1 Przemek Kitszel
2026-11-10 14:07 ` [PATCH net-next v5 06/15] ice: bump to 256qs for VF Przemek Kitszel
2026-11-12 23:07   ` netdev-bot+sashiko
2026-11-10 14:07 ` [PATCH net-next v5 07/15] iavf: extend iavf_configure_queues() to support more queues Przemek Kitszel
2026-11-12 23:07   ` netdev-bot+sashiko
2026-11-13 12:07   ` Loktionov, Aleksandr
2026-11-10 14:07 ` [PATCH net-next v5 08/15] iavf: temporary rename of IAVF_MAX_REQ_QUEUES to IAVF_MAX_REQ_QUEUES_VCV1 Przemek Kitszel
2026-11-10 14:07 ` [PATCH net-next v5 09/15] iavf: increase max number of queues to 256 Przemek Kitszel
2026-11-12 23:07   ` netdev-bot+sashiko
2026-11-10 14:07 ` [PATCH net-next v5 10/15] iavf: use new opcodes to request more than 16 queues Przemek Kitszel
2026-11-12 12:57   ` Petr Oros
2026-11-12 23:07   ` netdev-bot+sashiko
2026-11-10 14:07 ` [PATCH net-next v5 11/15] ice: introduce handling of virtchnl LARGE VF opcodes Przemek Kitszel
2026-11-12 23:07   ` netdev-bot+sashiko
2026-11-10 14:07 ` [PATCH net-next v5 12/15] devlink: give user option to allocate resources Przemek Kitszel
2026-11-13 12:08   ` Loktionov, Aleksandr
2026-11-19  1:00   ` Jakub Kicinski
2026-11-19 14:02     ` Przemek Kitszel [this message]
2026-11-10 14:07 ` [PATCH net-next v5 13/15] ice: represent RSS LUTs as devlink resources Przemek Kitszel
2026-11-12 23:07   ` netdev-bot+sashiko
2026-11-19  1:11   ` Jakub Kicinski
2026-11-10 14:07 ` [PATCH net-next v5 14/15] devlink: add devlink_alloc_drv() Przemek Kitszel
2026-11-10 14:48   ` Jiri Pirko
2026-11-12 23:07   ` netdev-bot+sashiko
2026-11-10 14:07 ` [PATCH net-next v5 15/15] ice: support up to 256 VF queues Przemek Kitszel
2026-11-12 23:07   ` netdev-bot+sashiko
2026-11-12 12:57 ` [PATCH net-next v5 00/15] devlink, mlx5, iavf, ice: XLVF for iavf Petr Oros
2026-11-13 12:10 ` Przemek Kitszel
2026-11-19  1:12 ` Jakub Kicinski
2026-11-19 13:10   ` Przemek Kitszel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=947c9fee-8d85-4b90-9018-7c021da9823e@intel.com \
    --to=przemyslaw.kitszel@intel.com \
    --cc=aleksandr.loktionov@intel.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=anzaki@gmail.com \
    --cc=brett.creeley@amd.com \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=jacob.e.keller@intel.com \
    --cc=jedrzej.jagielski@intel.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=mbloch@nvidia.com \
    --cc=mschmidt@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=ohartoov@nvidia.com \
    --cc=pabeni@redhat.com \
    --cc=poros@redhat.com \
    --cc=rdunlap@infradead.org \
    --cc=saeedm@nvidia.com \
    --cc=skhan@linuxfoundation.org \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox