[PATCH 0/2] riscv: dts: spacemit: Fix phy id check for the phy

[PATCH 0/2] riscv: dts: spacemit: Fix phy id check for the phy

[Inochi Amaoto]

As reported, the phy framework can not detected the phy id correctly
when reiniting this. So add the phy id compatible string to the
etherenet phy, so the phy can be reinit successfully.

Note: separate this patchset as two patch for backport if necessary.

Inochi Amaoto (2):
  riscv: dts: spacemit: Fix phy id check for the phy on pico-itx board
  riscv: dts: spacemit: Fix phy id check for the phy on com260 board

 arch/riscv/boot/dts/spacemit/k3-com260.dtsi  | 3 ++-
 arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

--
2.55.0

[PATCH 1/2] riscv: dts: spacemit: Fix phy id check for the phy on pico-itx board

[Inochi Amaoto]

Current phy framework can not reinit the phy correctly, as it will
assert the phy reset GPIO so the phy id can not be readed. Setting
the phy id of board pico-itx manually so the phy id dectection can
be skipped.

Fixes: 74657a376960 ("riscv: dts: spacemit: Add ethernet device for K3")
Reported-by: E Shattow <e@freeshell.de>
Reported-by: Inochi Amaoto <inochiama@gmail.com>
Closes: https://lore.kernel.org/netdev/20260712045233.800748-1-inochiama@gmail.com
Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
Tested-by: E Shattow <e@freeshell.de>
---
 arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
index b2a7d2d0d3a8..b9d2de878f38 100644
--- a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
+++ b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
@@ -196,7 +196,8 @@ &eth0 {
 
 	mdio {
 		phy0: phy@1 {
-			compatible = "ethernet-phy-ieee802.3-c22";
+			compatible = "ethernet-phy-id001c.c916",
+				     "ethernet-phy-ieee802.3-c22";
 			reg = <1>;
 			reset-gpios = <&gpio 0 15 GPIO_ACTIVE_LOW>;
 			reset-assert-us = <10000>;
-- 
2.55.0

[PATCH 2/2] riscv: dts: spacemit: Fix phy id check for the phy on com260 board

[Inochi Amaoto]

Current phy framework can not reinit the phy correctly, as it will
assert the phy reset GPIO so the phy id can not be readed. Setting
the phy id of board com260 manually so the phy id dectection can
be skipped.

Fixes: cfe5c91cb73c ("riscv: dts: spacemit: k3: Initial support for CoM260-IFX board")
Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
---
 arch/riscv/boot/dts/spacemit/k3-com260.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/riscv/boot/dts/spacemit/k3-com260.dtsi b/arch/riscv/boot/dts/spacemit/k3-com260.dtsi
index b704b537385c..a26b18aabec1 100644
--- a/arch/riscv/boot/dts/spacemit/k3-com260.dtsi
+++ b/arch/riscv/boot/dts/spacemit/k3-com260.dtsi
@@ -174,7 +174,8 @@ &eth1 {
 
 	mdio {
 		phy1: phy@1 {
-			compatible = "ethernet-phy-ieee802.3-c22";
+			compatible = "ethernet-phy-id001c.c916",
+				     "ethernet-phy-ieee802.3-c22";
 			reg = <1>;
 			reset-gpios = <&gpio 1 5 GPIO_ACTIVE_LOW>;
 			reset-assert-us = <10000>;
-- 
2.55.0

Re: [PATCH 0/2] riscv: dts: spacemit: Fix phy id check for the phy

[Yixun Lan]

Hi Inochi,

On 08:58 Sat 25 Jul     , Inochi Amaoto wrote:
> As reported, the phy framework can not detected the phy id correctly
> when reiniting this. So add the phy id compatible string to the
> etherenet phy, so the phy can be reinit successfully.
> 
> Note: separate this patchset as two patch for backport if necessary.
> 
> Inochi Amaoto (2):
>   riscv: dts: spacemit: Fix phy id check for the phy on pico-itx board
>   riscv: dts: spacemit: Fix phy id check for the phy on com260 board
> 
for the series, with R-B

Reviewed-by: Yixun Lan <dlan@kernel.org>

>  arch/riscv/boot/dts/spacemit/k3-com260.dtsi  | 3 ++-
>  arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> --
> 2.55.0
> 

-- 
Yixun Lan (dlan)

Re: [PATCH 1/2] riscv: dts: spacemit: Fix phy id check for the phy on pico-itx board

[E Shattow]

Hi Inochi,

On 7/24/26 17:58, Inochi Amaoto wrote:
> Current phy framework can not reinit the phy correctly, as it will
> assert the phy reset GPIO so the phy id can not be readed. Setting
> the phy id of board pico-itx manually so the phy id dectection can
> be skipped.
> 
> Fixes: 74657a376960 ("riscv: dts: spacemit: Add ethernet device for K3")
> Reported-by: E Shattow <e@freeshell.de>
> Reported-by: Inochi Amaoto <inochiama@gmail.com>
> Closes: https://lore.kernel.org/netdev/20260712045233.800748-1-inochiama@gmail.com
> Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
> Tested-by: E Shattow <e@freeshell.de>
> ---
>  arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> index b2a7d2d0d3a8..b9d2de878f38 100644
> --- a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> +++ b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> @@ -196,7 +196,8 @@ &eth0 {
>  
>  	mdio {
>  		phy0: phy@1 {
> -			compatible = "ethernet-phy-ieee802.3-c22";
> +			compatible = "ethernet-phy-id001c.c916",
> +				     "ethernet-phy-ieee802.3-c22";
>  			reg = <1>;
>  			reset-gpios = <&gpio 0 15 GPIO_ACTIVE_LOW>;
>  			reset-assert-us = <10000>;

Looks good to me, aside from commit message spelling and grammar nits
("re-initialize", "read", "detection"). Yixun may just fix in-flight, my
R-by and T-by tags can stay.

Thanks! -E

Re: [PATCH 1/2] riscv: dts: spacemit: Fix phy id check for the phy on pico-itx board

[Yixun Lan]

Hi E Shattow,

On 01:12 Sat 25 Jul     , E Shattow wrote:
> Hi Inochi,
> 
> On 7/24/26 17:58, Inochi Amaoto wrote:
> > Current phy framework can not reinit the phy correctly, as it will
> > assert the phy reset GPIO so the phy id can not be readed. Setting
> > the phy id of board pico-itx manually so the phy id dectection can
> > be skipped.
> > 
> > Fixes: 74657a376960 ("riscv: dts: spacemit: Add ethernet device for K3")
> > Reported-by: E Shattow <e@freeshell.de>
> > Reported-by: Inochi Amaoto <inochiama@gmail.com>
> > Closes: https://lore.kernel.org/netdev/20260712045233.800748-1-inochiama@gmail.com
> > Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
> > Tested-by: E Shattow <e@freeshell.de>
> > ---
> >  arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> > index b2a7d2d0d3a8..b9d2de878f38 100644
> > --- a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> > +++ b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> > @@ -196,7 +196,8 @@ &eth0 {
> >  
> >  	mdio {
> >  		phy0: phy@1 {
> > -			compatible = "ethernet-phy-ieee802.3-c22";
> > +			compatible = "ethernet-phy-id001c.c916",
> > +				     "ethernet-phy-ieee802.3-c22";
> >  			reg = <1>;
> >  			reset-gpios = <&gpio 0 15 GPIO_ACTIVE_LOW>;
> >  			reset-assert-us = <10000>;
> 
> Looks good to me, aside from commit message spelling and grammar nits
> ("re-initialize", "read", "detection"). Yixun may just fix in-flight, my
> R-by and T-by tags can stay.
> 
Yes, I will fix them while applying, no need to resend, thanks for review

-- 
Yixun Lan (dlan)

Re: [PATCH 1/2] riscv: dts: spacemit: Fix phy id check for the phy on pico-itx board

[Andrew Lunn]

On Sat, Jul 25, 2026 at 08:58:02AM +0800, Inochi Amaoto wrote:
> Current phy framework can not reinit the phy correctly, as it will
> assert the phy reset GPIO so the phy id can not be readed. Setting
> the phy id of board pico-itx manually so the phy id dectection can
> be skipped.
> 
> Fixes: 74657a376960 ("riscv: dts: spacemit: Add ethernet device for K3")
> Reported-by: E Shattow <e@freeshell.de>
> Reported-by: Inochi Amaoto <inochiama@gmail.com>
> Closes: https://lore.kernel.org/netdev/20260712045233.800748-1-inochiama@gmail.com
> Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
> Tested-by: E Shattow <e@freeshell.de>
> ---
>  arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> index b2a7d2d0d3a8..b9d2de878f38 100644
> --- a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> +++ b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> @@ -196,7 +196,8 @@ &eth0 {
>  
>  	mdio {
>  		phy0: phy@1 {
> -			compatible = "ethernet-phy-ieee802.3-c22";
> +			compatible = "ethernet-phy-id001c.c916",
> +				     "ethernet-phy-ieee802.3-c22";

There was a patch recently from one of the DT Maintainers removing the
-c22 compatible when there was a specific PHY ID. I did not look into
why. Does this pass all the binding tool checks?

     Andrew