From: Daniel Borkmann <daniel@iogearbox.net>
To: Yafang Shao <laoar.shao@gmail.com>,
kafai@fb.com, brakmo@fb.com, ast@kernel.org
Cc: netdev@vger.kernel.org, shaoyafang@didiglobal.com
Subject: Re: [PATCH v2 bpf-next] bpf: use the proper optlen when doing strncpy in bpf_getsockopt()
Date: Thu, 24 Jan 2019 12:24:43 +0100 [thread overview]
Message-ID: <9645e625-e090-2fa4-b570-0862ddfc5b19@iogearbox.net> (raw)
In-Reply-To: <1548306994-877-1-git-send-email-laoar.shao@gmail.com>
On 01/24/2019 06:16 AM, Yafang Shao wrote:
> As strncpy(..., TCP_CA_NAME_MAX-1) is used in bpf_setsockopt(),
> this change will make it more consistent with the bpf_setsockopt() above.
>
> Acked-by: Martin KaFai Lau <kafai@fb.com>
> Acked-by: Lawrence Brakmo <brakmo@fb.com>
> Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
While not wrong, I also don't think it improves much either. As mentioned,
that code is totally fine as it currently is.
prev parent reply other threads:[~2019-01-24 11:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 5:16 [PATCH v2 bpf-next] bpf: use the proper optlen when doing strncpy in bpf_getsockopt() Yafang Shao
2019-01-24 11:24 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9645e625-e090-2fa4-b570-0862ddfc5b19@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=brakmo@fb.com \
--cc=kafai@fb.com \
--cc=laoar.shao@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shaoyafang@didiglobal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox