Netdev List
 help / color / mirror / Atom feed
From: Jacob Wen <jian.w.wen@oracle.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [PATCH net] net_sched: sch_mqprio: handle return value of mqprio_queue_get
Date: Tue, 11 Jun 2019 08:27:41 +0800	[thread overview]
Message-ID: <9812dba9-e7c5-c0c0-7065-1cf5f04e7958@oracle.com> (raw)
In-Reply-To: <CAM_iQpXk_-4zKJXkEDVUKUYxEpa8QNa8u2iD4BVxTTWQe=J4cA@mail.gmail.com>

Hi Cong,

This was detected by a tool.

Thanks for the review :)

I will abandon the patch.

On 6/11/19 2:19 AM, Cong Wang wrote:
> On Sun, Jun 9, 2019 at 11:41 PM Jacob Wen <jian.w.wen@oracle.com> wrote:
>> It may return NULL thus we can't ignore it.
> How is this possible? All of the callers should have validated
> the 'cl' before calling this, for example by calling ->find().
>
> I don't see it is possible to be NULL at this point.
>
> Did you see a real crash? If so, please put the full stack trace
> in your changelog.
>
> Thanks!

      reply	other threads:[~2019-06-11  0:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-10  6:38 [PATCH net] net_sched: sch_mqprio: handle return value of mqprio_queue_get Jacob Wen
2019-06-10 16:05 ` David Miller
2019-06-10 16:06   ` David Miller
2019-06-10 18:19 ` Cong Wang
2019-06-11  0:27   ` Jacob Wen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9812dba9-e7c5-c0c0-7065-1cf5f04e7958@oracle.com \
    --to=jian.w.wen@oracle.com \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox